Re: [dpdk-dev] [PATCH] libs/power: add p-state driver compatibility

2018-12-13 Thread Burakov, Anatoly
On 13-Dec-18 1:46 PM, Liang, Ma wrote: 13 Dec 11:16, Burakov, Anatoly wrote: On 13-Dec-18 10:58 AM, Liang, Ma wrote: On 10 Dec 16:08, Burakov, Anatoly wrote: Hi Liang, General comment: please do not break up log strings onto multiple lines. It makes it harder to grep the codebase. Checkpat

Re: [dpdk-dev] [PATCH] libs/power: add p-state driver compatibility

2018-12-13 Thread Liang, Ma
13 Dec 11:16, Burakov, Anatoly wrote: > On 13-Dec-18 10:58 AM, Liang, Ma wrote: > > On 10 Dec 16:08, Burakov, Anatoly wrote: > > > > > Hi Liang, > > > > > > General comment: please do not break up log strings onto multiple lines. > > > It > > > makes it harder to grep the codebase. Checkpatch w

Re: [dpdk-dev] [PATCH] libs/power: add p-state driver compatibility

2018-12-13 Thread Burakov, Anatoly
On 13-Dec-18 10:58 AM, Liang, Ma wrote: On 10 Dec 16:08, Burakov, Anatoly wrote: Hi Liang, General comment: please do not break up log strings onto multiple lines. It makes it harder to grep the codebase. Checkpatch will not warn about log strings going over 80 characters. agree, I will updat

Re: [dpdk-dev] [PATCH] libs/power: add p-state driver compatibility

2018-12-13 Thread Liang, Ma
On 10 Dec 16:08, Burakov, Anatoly wrote: > Hi Liang, > > General comment: please do not break up log strings onto multiple lines. It > makes it harder to grep the codebase. Checkpatch will not warn about log > strings going over 80 characters. agree, I will update in next version > > > --- > >

Re: [dpdk-dev] [PATCH] libs/power: add p-state driver compatibility

2018-12-10 Thread Burakov, Anatoly
On 23-Nov-18 11:33 AM, Liang Ma wrote: Previously, in order to use the power library, it was necessary for the user to disable the intel_pstate driver by adding “intel_pstate=disable” to the kernel command line for the system, which causes the acpi_cpufreq driver to be loaded in its place. This

[dpdk-dev] [PATCH] libs/power: add p-state driver compatibility

2018-11-23 Thread Liang Ma
Previously, in order to use the power library, it was necessary for the user to disable the intel_pstate driver by adding “intel_pstate=disable” to the kernel command line for the system, which causes the acpi_cpufreq driver to be loaded in its place. This patch adds the ability for the power libr