[dpdk-dev] [PATCH] librte_vhost: Fix the path test issue

2014-11-06 Thread Thomas Monjalon
> > Commit aec8283d47d4e4366b6 fixes the compilation issue, but it leads to > > one runtime issue: early exit wrongly. In some case, 'path' is NULL, but > > 'resolved_path' has effective path, it should continue going ahead rather > > than exit. > > > > Signed-off-by: Changchun Ouyang > > Acked-

[dpdk-dev] [PATCH] librte_vhost: Fix the path test issue

2014-11-06 Thread Xie, Huawei
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ouyang Changchun > Sent: Monday, November 03, 2014 1:12 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] librte_vhost: Fix the path test issue > > Commit aec8283d47d4e4366b6 fixes

[dpdk-dev] [PATCH] librte_vhost: Fix the path test issue

2014-11-06 Thread Xie, Huawei
> -Original Message- > From: Ouyang, Changchun > Sent: Wednesday, November 05, 2014 10:20 PM > To: Xie, Huawei; dev at dpdk.org > Cc: Ouyang, Changchun > Subject: RE: [dpdk-dev] [PATCH] librte_vhost: Fix the path test issue > > Hi Huawei, > Thanks for the com

[dpdk-dev] [PATCH] librte_vhost: Fix the path test issue

2014-11-06 Thread Ouyang, Changchun
Hi Huawei, Thanks for the comments, And my response as follows. > -Original Message- > From: Xie, Huawei > Sent: Thursday, November 6, 2014 10:39 AM > To: Ouyang, Changchun; dev at dpdk.org > Subject: RE: [dpdk-dev] [PATCH] librte_vhost: Fix the path test issue > &g

[dpdk-dev] [PATCH] librte_vhost: Fix the path test issue

2014-11-06 Thread Xie, Huawei
> path = realpath(memfile, resolved_path); > - if (path == NULL) { > + if ((path == NULL) && (strlen(resolved_path) == 0)) { > RTE_LOG(ERR, VHOST_CONFIG, > "(%"PRIu64") Failed to resolve fd directory\n", >

[dpdk-dev] [PATCH] librte_vhost: Fix the path test issue

2014-11-03 Thread Ouyang Changchun
Commit aec8283d47d4e4366b6 fixes the compilation issue, but it leads to one runtime issue: early exit wrongly. In some case, 'path' is NULL, but 'resolved_path' has effective path, it should continue going ahead rather than exit. Signed-off-by: Changchun Ouyang --- lib/librte_vhost/virtio-net