[dpdk-dev] [PATCH] librte_pmd_ixgbe: Add queue start failure check

2015-01-27 12:00, Qiu, Michael: > On 1/27/2015 6:02 PM, Thomas Monjalon wrote: > > Hi Michael, > > > > I'm clearly not the maintainer of ixgbe, so I'd prefer someone else > > reviewing this patch. However I have few comments. > > Thanks Thomas, > > I will send v2 with your comments. > > But who

[dpdk-dev] [PATCH] librte_pmd_ixgbe: Add queue start failure check

On 1/27/2015 6:02 PM, Thomas Monjalon wrote: > Hi Michael, > > I'm clearly not the maintainer of ixgbe, so I'd prefer someone else > reviewing this patch. However I have few comments. Thanks Thomas, I will send v2 with your comments. But who maintains ixgbe? I would like add him(or she) to the c

[dpdk-dev] [PATCH] librte_pmd_ixgbe: Add queue start failure check

Hi Michael, I'm clearly not the maintainer of ixgbe, so I'd prefer someone else reviewing this patch. However I have few comments. 2015-01-15 22:45, Michael Qiu: > - ixgbe_dev_rxtx_start(dev); > + err = ixgbe_dev_rxtx_start(dev); > + if (err < 0) { > + PMD_INIT_LOG(ERR, "U

[dpdk-dev] [PATCH] librte_pmd_ixgbe: Add queue start failure check

Any comments? On 2015/1/15 22:45, Qiu, Michael wrote: > For ixgbe, when queue start failure, for example, mbuf allocate > failure, the device will still start success, which could be > an issue. > > Add return status check of queue start to avoid this issue. > > Signed-off-by: Michael Qiu > --- >

[dpdk-dev] [PATCH] librte_pmd_ixgbe: Add queue start failure check

For ixgbe, when queue start failure, for example, mbuf allocate failure, the device will still start success, which could be an issue. Add return status check of queue start to avoid this issue. Signed-off-by: Michael Qiu --- lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 6 +- lib/librte_pmd_ixgbe