This patch fixes code style issues and refines some comments in vhost library.
Signed-off-by: Huawei Xie
---
lib/librte_vhost/eventfd_link/eventfd_link.c | 244 ++---
lib/librte_vhost/eventfd_link/eventfd_link.h | 127 ++-
lib/librte_vhost/rte_virtio_net.h|
2014-11-05 21:55, Xie, Huawei:
> > 2014-11-05 21:21, Xie, Huawei:
> Btw, for alignment in structure, I see different projects use different way,
> some use tab, and some use space(between type and var), do we have rules for
> this?
> {
> Typevar1
> Typevar2
> }
I prefer using
> To: Xie, Huawei
> > Cc: dev at dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH] lib/librte_vhost: code style fixes
> >
> > Hi Huawei,
> >
> > checkpatch.pl reports some errors of types PREFER_PR_LEVEL
> > and MISORDERED_TYPE.
> >
> > --
> > Thomas
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Wednesday, November 05, 2014 2:25 PM
> To: Xie, Huawei
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] lib/librte_vhost: code style fixes
>
> 2014-11-05 21:21, Xie, H
Hi Huawei,
checkpatch.pl reports some errors of types PREFER_PR_LEVEL
and MISORDERED_TYPE.
--
Thomas
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Wednesday, November 05, 2014 1:42 PM
> To: Xie, Huawei
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] lib/librte_vhost: code style fixes
>
> Hi Huawei,
>
> checkpatch.pl reports som
:(.
Resent done. Please drop this patch.
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Wednesday, November 05, 2014 2:10 AM
> To: Xie, Huawei
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] lib/librte_vhost: code s
This patch fixes code style issues and refines some comments in vhost library.
---
lib/librte_vhost/eventfd_link/eventfd_link.c | 244 ++---
lib/librte_vhost/eventfd_link/eventfd_link.h | 127 ++-
lib/librte_vhost/rte_virtio_net.h| 3 +-
lib/librte_vhost/vho
This patch fixes code style issues and refines some comments in vhost library.
---
lib/librte_vhost/eventfd_link/eventfd_link.c | 244 ++---
lib/librte_vhost/eventfd_link/eventfd_link.h | 127 ++-
lib/librte_vhost/rte_virtio_net.h| 3 +-
lib/librte_vhost/vho
Hi Huawei,
Please set a Signed-off in your patch.
2014-11-05 12:42, Huawei Xie:
> This patch fixes code style issues and refines some comments in vhost library.
>
>
> ---
> lib/librte_vhost/eventfd_link/eventfd_link.c | 244 ++---
> lib/librte_vhost/eventfd_link/eventfd_link.h
10 matches
Mail list logo
