Re: [dpdk-dev] [PATCH] lib/librte_ip_frag:fix ip_frag_key_cmp bug

2018-10-28 Thread Thomas Monjalon
24/08/2018 13:04, Ananyev, Konstantin: > From: Li Han [mailto:han@zte.com.cn] > > > > in struct ip_frag_key,src_dst[] type is uint64_t. > > but "val" which to store the calc restult ,type is uint32_t. > > we may lost high 32 bit key. and function return value is int, > > but it won't return <

Re: [dpdk-dev] [PATCH] lib/librte_ip_frag:fix ip_frag_key_cmp bug

2018-08-24 Thread Ananyev, Konstantin
> -Original Message- > From: Li Han [mailto:han@zte.com.cn] > Sent: Thursday, August 2, 2018 3:01 AM > To: Ananyev, Konstantin > Cc: dev@dpdk.org; Li Han > Subject: [PATCH] [dpdk-dev] lib/librte_ip_frag:fix ip_frag_key_cmp bug > > in struct ip_frag_key,src_dst[] type is uint64_t.

Re: [dpdk-dev] [PATCH] lib/librte_ip_frag:fix ip_frag_key_cmp bug

2018-08-09 Thread Ferruh Yigit
On 8/2/2018 3:01 AM, Li Han wrote: > in struct ip_frag_key,src_dst[] type is uint64_t. > but "val" which to store the calc restult ,type is uint32_t. > we may lost high 32 bit key. and function return value is int, > but it won't return < 0. > > Signed-off-by: Li Han Fix looks good to me [1], bu

Re: [dpdk-dev] [PATCH] lib/librte_ip_frag:fix ip_frag_key_cmp bug

2018-08-05 Thread Thomas Monjalon
Konstantin, Is it candidate for last minute fix in 18.08? 02/08/2018 04:01, Li Han: > in struct ip_frag_key,src_dst[] type is uint64_t. > but "val" which to store the calc restult ,type is uint32_t. > we may lost high 32 bit key. and function return value is int, > but it won't return < 0. > > S

[dpdk-dev] [PATCH] lib/librte_ip_frag:fix ip_frag_key_cmp bug

2018-08-01 Thread Li Han
in struct ip_frag_key,src_dst[] type is uint64_t. but "val" which to store the calc restult ,type is uint32_t. we may lost high 32 bit key. and function return value is int, but it won't return < 0. Signed-off-by: Li Han --- lib/librte_ip_frag/ip_frag_common.h | 4 ++-- 1 file changed, 2 inserti