Re: [dpdk-dev] [PATCH] lib/cryptodev: fix driver name comparison

2019-03-06 Thread Anoob Joseph
rch, Pablo ; Yigit, Ferruh > ; Thomas Monjalon > Cc: Jerin Jacob Kollanukkaran ; Narayana Prasad Raju > Athreya ; dev@dpdk.org; Ankur Dwivedi > > Subject: Re: [dpdk-dev] [PATCH] lib/cryptodev: fix driver name comparison > > Hi Fiona, Akhil, > > > -Original Messa

Re: [dpdk-dev] [PATCH] lib/cryptodev: fix driver name comparison

2019-02-28 Thread Anoob Joseph
kkaran ; Narayana Prasad Raju > Athreya ; dev@dpdk.org; Ankur Dwivedi > ; Trahe, Fiona > Subject: Re: [dpdk-dev] [PATCH] lib/cryptodev: fix driver name comparison > > Hi Akhil, Anoob, > > > -Original Message- > > From: Akhil Goyal [mailto:akhil.go...@nxp.com]

Re: [dpdk-dev] [PATCH] lib/cryptodev: fix driver name comparison

2019-02-28 Thread Trahe, Fiona
: Jerin Jacob Kollanukkaran ; Narayana Prasad Raju > Athreya > ; dev@dpdk.org; Ankur Dwivedi > Subject: Re: [dpdk-dev] [PATCH] lib/cryptodev: fix driver name comparison > > > > On 2/28/2019 2:57 PM, Anoob Joseph wrote: > > Hi Akhil, > > > > Please se

Re: [dpdk-dev] [PATCH] lib/cryptodev: fix driver name comparison

2019-02-28 Thread Akhil Goyal
, Declan ; De >> Lara Guarch, Pablo ; Yigit, Ferruh >> ; Thomas Monjalon >> Cc: Jerin Jacob Kollanukkaran ; Narayana Prasad Raju >> Athreya ; dev@dpdk.org; Ankur Dwivedi >> >> Subject: Re: [dpdk-dev] [PATCH] lib/cryptodev: fix driver name comparison >&

Re: [dpdk-dev] [PATCH] lib/cryptodev: fix driver name comparison

2019-02-28 Thread Anoob Joseph
erin Jacob Kollanukkaran ; Narayana Prasad Raju > Athreya ; dev@dpdk.org; Ankur Dwivedi > > Subject: Re: [dpdk-dev] [PATCH] lib/cryptodev: fix driver name comparison > > Hi Anoob, > > On 2/28/2019 12:18 PM, Anoob Joseph wrote: > > Hi Akhil, Declan, Pablo, > > > > Ca

Re: [dpdk-dev] [PATCH] lib/cryptodev: fix driver name comparison

2019-02-28 Thread Akhil Goyal
Hi Anoob, On 2/28/2019 12:18 PM, Anoob Joseph wrote: > Hi Akhil, Declan, Pablo, > > Can you review this patch and share your thoughts? > > Thanks, > Anoob > >> -Original Message- >> From: Trahe, Fiona >> Sent: Monday, February 25, 2019 5:22 PM >> To: Anoob Joseph ; Akhil Goyal >> ; Dohert

Re: [dpdk-dev] [PATCH] lib/cryptodev: fix driver name comparison

2019-02-27 Thread Anoob Joseph
Hi Akhil, Declan, Pablo, Can you review this patch and share your thoughts? Thanks, Anoob > -Original Message- > From: Trahe, Fiona > Sent: Monday, February 25, 2019 5:22 PM > To: Anoob Joseph ; Akhil Goyal > ; Doherty, Declan ; De > Lara Guarch, Pablo ; Yigit, Ferruh > ; Thomas Monjalo

Re: [dpdk-dev] [PATCH] lib/cryptodev: fix driver name comparison

2019-02-25 Thread Trahe, Fiona
Hi Anoob > -Original Message- > From: Anoob Joseph [mailto:ano...@marvell.com] > Sent: Saturday, February 23, 2019 6:12 AM > To: Trahe, Fiona ; Akhil Goyal ; > Doherty, Declan > ; De Lara Guarch, Pablo > ; Yigit, Ferruh > ; Thomas Monjalon > Cc: Jerin Jacob Kollanukkaran ; Narayana Pras

Re: [dpdk-dev] [PATCH] lib/cryptodev: fix driver name comparison

2019-02-22 Thread Anoob Joseph
Hi Fiona, > -Original Message- > From: Trahe, Fiona > Sent: Friday, February 22, 2019 9:09 PM > To: Anoob Joseph ; Akhil Goyal ; > Doherty, Declan ; De Lara Guarch, Pablo > > Cc: Jerin Jacob Kollanukkaran ; Narayana Prasad Raju > Athreya ; dev@dpdk.org; Ankur Dwivedi > ; Trahe, Fiona >

Re: [dpdk-dev] [PATCH] lib/cryptodev: fix driver name comparison

2019-02-22 Thread Trahe, Fiona
Hi Anoob, > > > > @@ -542,8 +543,8 @@ rte_cryptodev_get_dev_id(const char *name) > > > > return -1; > > > > > > > > for (i = 0; i < cryptodev_globals.nb_devs; i++) > > > > - if ((strcmp(cryptodev_globals.devs[i].data->name, name) > > > > -

Re: [dpdk-dev] [PATCH] lib/cryptodev: fix driver name comparison

2019-02-21 Thread Anoob Joseph
ry 20, 2019 3:42 PM > > To: Akhil Goyal ; Doherty, Declan > > ; De Lara Guarch, Pablo > > > > Cc: Jerin Jacob Kollanukkaran ; Narayana Prasad > > Raju Athreya ; dev@dpdk.org; Ankur Dwivedi > > > > Subject: Re: [dpdk-dev] [PATCH] lib/cryptodev: fix driver na

Re: [dpdk-dev] [PATCH] lib/cryptodev: fix driver name comparison

2019-02-21 Thread Trahe, Fiona
Athreya > ; dev@dpdk.org; Ankur Dwivedi > Subject: Re: [dpdk-dev] [PATCH] lib/cryptodev: fix driver name comparison > > Hi Akhil, Declan, Pablo, > > Can you review this patch and share your thoughts? > > Thanks, > Anoob > > > -Original Message- >

Re: [dpdk-dev] [PATCH] lib/cryptodev: fix driver name comparison

2019-02-20 Thread Anoob Joseph
Hi Akhil, Declan, Pablo, Can you review this patch and share your thoughts? Thanks, Anoob > -Original Message- > From: Anoob Joseph > Sent: Monday, February 4, 2019 4:56 PM > To: Akhil Goyal ; Declan Doherty > ; Pablo de Lara > Cc: Anoob Joseph ; Jerin Jacob Kollanukkaran > ; Narayana P

[dpdk-dev] [PATCH] lib/cryptodev: fix driver name comparison

2019-02-04 Thread Anoob Joseph
The string compare to the length of driver name might give false positives when there are drivers with similar names (one being the subset of another). Following is such a naming which could result in false positive. 1. crypto_driver 2. crypto_driver1 When strncmp with len = strlen("crypto_driver