Re: [dpdk-dev] [PATCH] kvargs: trim spaces at the beginning and end of key and values

2019-07-01 Thread Olivier Matz
Hi, On Wed, May 15, 2019 at 10:41:07PM -0700, Mesut Ali Ergin wrote: > When arguments delimited with RTE_KVARGS_PAIRS_DELIM happen to have > spaces before and after the delimiter, the rte_kvargs_process() can not > match them to the intended key. For example, the first argument below > triggers th

Re: [dpdk-dev] [PATCH] kvargs: trim spaces at the beginning and end of key and values

2019-05-16 Thread Stephen Hemminger
dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH] kvargs: trim spaces at the beginning and > > end of > > key and values > > > > On Wed, 15 May 2019 22:41:07 -0700 > > Mesut Ali Ergin wrote: > > > > > +/* trim leading and trailing spa

Re: [dpdk-dev] [PATCH] kvargs: trim spaces at the beginning and end of key and values

2019-05-16 Thread Ergin, Mesut A
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Thursday, May 16, 2019 9:37 AM > To: Ergin, Mesut A > Cc: olivier.m...@6wind.com; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] kvargs: trim spaces at the beginning and e

Re: [dpdk-dev] [PATCH] kvargs: trim spaces at the beginning and end of key and values

2019-05-16 Thread Stephen Hemminger
On Wed, 15 May 2019 22:41:07 -0700 Mesut Ali Ergin wrote: > +/* trim leading and trailing spaces */ > +static char * > +trim_space(char *str) > +{ > + char *start, *end; > + > + for (start = str; *start; start++) { > + if (!isspace((unsigned char) start[0])) > +

[dpdk-dev] [PATCH] kvargs: trim spaces at the beginning and end of key and values

2019-05-15 Thread Mesut Ali Ergin
When arguments delimited with RTE_KVARGS_PAIRS_DELIM happen to have spaces before and after the delimiter, the rte_kvargs_process() can not match them to the intended key. For example, the first argument below triggers the support-multi-driver handler as expected, but the second one silently fails