Re: [dpdk-dev] [PATCH] keepalive: fix keepalive state alignment

2018-01-23 Thread Van Haaren, Harry
> From: Horton, Remy > Sent: Tuesday, January 23, 2018 10:17 AM > To: Andriy Berestovskyy ; Van Haaren, Harry > > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] keepalive: fix keepalive state alignment > > > On 22/01/2018 18:20, Andriy Berestovskyy wrote: > [.

Re: [dpdk-dev] [PATCH] keepalive: fix keepalive state alignment

2018-01-23 Thread Remy Horton
On 22/01/2018 18:20, Andriy Berestovskyy wrote: [..] On Fri, Jan 19, 2018 at 6:31 PM, Van Haaren, Harry wrote: These changes do reduce false-sharing however is there actually a performance benefit? A lot of cache space will be taken up if each core requires its own cache line, which will reduc

Re: [dpdk-dev] [PATCH] keepalive: fix keepalive state alignment

2018-01-22 Thread Andriy Berestovskyy
Hey Harry, Thanks for the review. On Fri, Jan 19, 2018 at 6:31 PM, Van Haaren, Harry wrote: > These changes do reduce false-sharing however is there actually a performance > benefit? A lot of cache space will be taken up if each core requires its own > cache line, which will reduce performance

Re: [dpdk-dev] [PATCH] keepalive: fix keepalive state alignment

2018-01-19 Thread Van Haaren, Harry
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Andriy Berestovskyy > Sent: Friday, January 19, 2018 2:48 PM > To: dev@dpdk.org > Cc: Horton, Remy > Subject: [dpdk-dev] [PATCH] keepalive: fix keepalive state alignment > > The __rte_cache_aligned was applied to the w

[dpdk-dev] [PATCH] keepalive: fix keepalive state alignment

2018-01-19 Thread Andriy Berestovskyy
The __rte_cache_aligned was applied to the whole array, not the array elements. This leads to a false sharing between the monitored cores. Fixes: e70a61ad50ab ("keepalive: export states") Cc: remy.hor...@intel.com Signed-off-by: Andriy Berestovskyy --- lib/librte_eal/common/rte_keepalive.c | 25