[dpdk-dev] [PATCH] i40e: fix shared code compile warning

2014-06-24 14:43, Ananyev, Konstantin: > Yes, it is much nicer to fix it in i40e_lan_hmc.c. > But I don't really want us to open that door. > So my vote would be to initial Mark's patch: add '-Wno-error' in the > Makefile. 2014-06-24 15:25, Zhang, Helin: > We should not modify code in shared code,

[dpdk-dev] [PATCH] i40e: fix shared code compile warning

Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, June 24, 2014 6:06 PM > To: Chen, Jing D > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] i40e: fix shared code compile warning > > 2014-0

[dpdk-dev] [PATCH] i40e: fix shared code compile warning

-Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ananyev, Konstantin Sent: Tuesday, June 24, 2014 10:44 PM To: Thomas Monjalon; Chen, Jing D Cc: dev at dpdk.org Subject: Re: [dpdk-dev] [PATCH] i40e: fix shared code compile warning Hi Thomas, > -Origi

[dpdk-dev] [PATCH] i40e: fix shared code compile warning

Hi Thomas, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > Sent: Tuesday, June 24, 2014 11:06 AM > To: Chen, Jing D > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] i40e: fix shared code compile warning > >

[dpdk-dev] [PATCH] i40e: fix shared code compile warning

From: "Chen Jing D(Mark)" Fix a compile warning in shared code on 32-bits RHEL6.3/6.5. Signed-off-by: Chen Jing D(Mark) --- lib/librte_pmd_i40e/Makefile |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/lib/librte_pmd_i40e/Makefile b/lib/librte_pmd_i40e/Makefile index 09

[dpdk-dev] [PATCH] i40e: fix shared code compile warning

2014-06-24 09:47, Chen, Jing D: > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > 2014-06-24 13:22, Chen Jing D: > > > +CFLAGS_i40e_lan_hmc.o += -Wno-error > > > > I know we shouldn't modify base drivers. But this one seems to be an > > important error. In such case, we already mo

[dpdk-dev] [PATCH] i40e: fix shared code compile warning

Hi, 2014-06-24 13:22, Chen Jing D: > Fix a compile warning in shared code on 32-bits RHEL6.3/6.5. > > Signed-off-by: Chen Jing D(Mark) In such case you should show the error message in the log. lib/librte_pmd_i40e/i40e/i40e_lan_hmc.c:917: error: integer constant is too large for

[dpdk-dev] [PATCH] i40e: fix shared code compile warning

Hi Thomas, -Original Message- From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] Sent: Tuesday, June 24, 2014 4:47 PM To: Chen, Jing D Cc: dev at dpdk.org Subject: Re: [dpdk-dev] [PATCH] i40e: fix shared code compile warning Hi, 2014-06-24 13:22, Chen Jing D: > Fix a comp