Hi Huawei,
2014-12-05 04:56, Xie, Huawei:
> Hi Thomas:
> I will continue work on this fix.
> Do you have comments to the v4 patch?
> For Bruce's comment, I add some descriptive commit message for the commit.
> For the constant number, I define a macro as the wrapper for the VFA array
> index and
Hi,
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Thursday, December 4, 2014 11:33 PM
> To: Chen, Jing D
> Cc: dev at dpdk.org; Qiu, Michael
> Subject: Re: [dpdk-dev] [PATCH] i40e: Fix a vlan bug
>
> 2014-12-04 14:29
Hi Thomas:
I will continue work on this fix.
Do you have comments to the v4 patch?
For Bruce's comment, I add some descriptive commit message for the commit.
For the constant number, I define a macro as the wrapper for the VFA array
index and value.
One question is it isn't based on latest commit
From: "Chen Jing D(Mark)"
i40e uses an bitmap array to store those vlan tags that are set by
application. In function i40e_set_vlan_filter, it stores vlan tag
to wrong place. This change will fix it.
Signed-off-by: Chen Jing D(Mark)
---
lib/librte_pmd_i40e/i40e_ethdev.c | 11 ---
1 f
i's fix is superseded by this one
Thank you
--
Thomas
> > PS: please don't top post.
>
> I apologized for top post.
>
> >
> > --
> > Thomas
> >
> > > > -Original Message-
> > > > From: Thomas Monjalon [mailto:thomas.monjalon at
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Thursday, December 4, 2014 6:39 PM
> To: Chen, Jing D
> Cc: dev at dpdk.org; Qiu, Michael
> Subject: Re: [dpdk-dev] [PATCH] i40e: Fix a vlan bug
>
> 2014-12-04 10:30, Chen
> > Sent: Thursday, December 04, 2014 6:26 PM
> > To: Chen, Jing D
> > Cc: dev at dpdk.org; Qiu, Michael
> > Subject: Re: [dpdk-dev] [PATCH] i40e: Fix a vlan bug
> >
> > 2014-12-04 10:18, Qiu, Michael:
> > > Hi Mark,
> > >
> > > I think
2014-12-04 10:18, Qiu, Michael:
> Hi Mark,
>
> I think Huawei (huawei.xie at intel.com) has one patch set to fix this issue.
>
> If your patch is totally different with him:
>
> [dpdk-dev] [PATCH v4 0/2] lib/librte_pmd_i40e: set vlan filter fix
>
> please ignore my comments :)
>
> But you both
at dpdk.org; Qiu, Michael
> Subject: Re: [dpdk-dev] [PATCH] i40e: Fix a vlan bug
>
> 2014-12-04 10:18, Qiu, Michael:
> > Hi Mark,
> >
> > I think Huawei (huawei.xie at intel.com) has one patch set to fix this
> > issue.
> >
> > If your patch is totally dif
Yes, the same to his. As he is in vacation, I'd like to send out patch for him.
> -Original Message-
> From: Qiu, Michael
> Sent: Thursday, December 04, 2014 6:19 PM
> To: Chen, Jing D; dev at dpdk.org
> Cc: Xie, Huawei
> Subject: Re: [dpdk-dev] [PATCH] i40e: Fix
Hi Mark,
I think Huawei (huawei.xie at intel.com) has one patch set to fix this issue.
If your patch is totally different with him:
[dpdk-dev] [PATCH v4 0/2] lib/librte_pmd_i40e: set vlan filter fix
please ignore my comments :)
But you both calculation are different.
Thanks,
Michael
On 12/4/2
11 matches
Mail list logo
