Re: [dpdk-dev] [PATCH] hash: document breakage with multi-writer thread

2020-11-26 Thread Thomas Monjalon
16/06/2020 18:12, Thomas Monjalon: > 05/06/2020 20:35, Stephen Hemminger: > > On Thu, 4 Jun 2020 10:17:31 -0700 > > Stephen Hemminger wrote: > > > > > The code in rte_cuckoo_hash multi-writer support is broken if write > > > operations are called from a non-EAL thread. > > > > > > rte_lcore_id(

Re: [dpdk-dev] [PATCH] hash: document breakage with multi-writer thread

2020-06-16 Thread Thomas Monjalon
05/06/2020 20:35, Stephen Hemminger: > On Thu, 4 Jun 2020 10:17:31 -0700 > Stephen Hemminger wrote: > > > The code in rte_cuckoo_hash multi-writer support is broken if write > > operations are called from a non-EAL thread. > > > > rte_lcore_id() wil return LCORE_ID_ANY (UINT32_MAX) for non EAL

Re: [dpdk-dev] [PATCH] hash: document breakage with multi-writer thread

2020-06-05 Thread Stephen Hemminger
On Thu, 4 Jun 2020 10:17:31 -0700 Stephen Hemminger wrote: > The code in rte_cuckoo_hash multi-writer support is broken if write > operations are called from a non-EAL thread. > > rte_lcore_id() wil return LCORE_ID_ANY (UINT32_MAX) for non EAL > thread and that leads to using wrong local cache.

Re: [dpdk-dev] [PATCH] hash: document breakage with multi-writer thread

2020-06-04 Thread Wang, Yipeng1
> -Original Message- > From: Stephen Hemminger > Sent: Thursday, June 4, 2020 10:18 AM > To: Wang, Yipeng1 ; Gobriel, Sameh > ; Richardson, Bruce > > Cc: dev@dpdk.org; Stephen Hemminger ; > honnappa.nagaraha...@arm.com; De Lara Guarch, Pablo > > Subject: [PATCH] hash: document breakage w

Re: [dpdk-dev] [PATCH] hash: document breakage with multi-writer thread

2020-06-04 Thread Stephen Hemminger
On Thu, 4 Jun 2020 20:22:06 + "Wang, Yipeng1" wrote: > > -Original Message- > > From: Honnappa Nagarahalli > > Sent: Thursday, June 4, 2020 12:34 PM > > To: Wang, Yipeng1 ; Stephen Hemminger > > > > Cc: Gobriel, Sameh ; Richardson, Bruce > > ; dev@dpdk.org; De Lara Guarch, Pablo > >

Re: [dpdk-dev] [PATCH] hash: document breakage with multi-writer thread

2020-06-04 Thread Wang, Yipeng1
> -Original Message- > From: Honnappa Nagarahalli > Sent: Thursday, June 4, 2020 12:34 PM > To: Wang, Yipeng1 ; Stephen Hemminger > > Cc: Gobriel, Sameh ; Richardson, Bruce > ; dev@dpdk.org; De Lara Guarch, Pablo > ; nd ; Honnappa > Nagarahalli ; nd > Subject: RE: [PATCH] hash: document

Re: [dpdk-dev] [PATCH] hash: document breakage with multi-writer thread

2020-06-04 Thread Honnappa Nagarahalli
> > > > > > > > > Subject: [PATCH] hash: document breakage with multi-writer > > > > > thread > > > > > > > > > > The code in rte_cuckoo_hash multi-writer support is broken if > > > > > write operations are called from a non-EAL thread. > > > > > > > > > > rte_lcore_id() wil return LCORE_ID_ANY (

Re: [dpdk-dev] [PATCH] hash: document breakage with multi-writer thread

2020-06-04 Thread Wang, Yipeng1
> > > > > > > > > > Subject: [PATCH] hash: document breakage with multi-writer thread > > > > > > > > The code in rte_cuckoo_hash multi-writer support is broken if > > > > write operations are called from a non-EAL thread. > > > > > > > > rte_lcore_id() wil return LCORE_ID_ANY (UINT32_MAX) for non

Re: [dpdk-dev] [PATCH] hash: document breakage with multi-writer thread

2020-06-04 Thread Honnappa Nagarahalli
> > > > > > > Subject: [PATCH] hash: document breakage with multi-writer thread > > > > > > The code in rte_cuckoo_hash multi-writer support is broken if write > > > operations are called from a non-EAL thread. > > > > > > rte_lcore_id() wil return LCORE_ID_ANY (UINT32_MAX) for non EAL > > > threa

Re: [dpdk-dev] [PATCH] hash: document breakage with multi-writer thread

2020-06-04 Thread Stephen Hemminger
On Thu, 4 Jun 2020 17:51:43 + Honnappa Nagarahalli wrote: > > > > Subject: [PATCH] hash: document breakage with multi-writer thread > > > > The code in rte_cuckoo_hash multi-writer support is broken if write > > operations are called from a non-EAL thread. > > > > rte_lcore_id() wil retur

Re: [dpdk-dev] [PATCH] hash: document breakage with multi-writer thread

2020-06-04 Thread Honnappa Nagarahalli
> Subject: [PATCH] hash: document breakage with multi-writer thread > > The code in rte_cuckoo_hash multi-writer support is broken if write > operations are called from a non-EAL thread. > > rte_lcore_id() wil return LCORE_ID_ANY (UINT32_MAX) for non EAL thread > and that leads to using wrong l

[dpdk-dev] [PATCH] hash: document breakage with multi-writer thread

2020-06-04 Thread Stephen Hemminger
The code in rte_cuckoo_hash multi-writer support is broken if write operations are called from a non-EAL thread. rte_lcore_id() wil return LCORE_ID_ANY (UINT32_MAX) for non EAL thread and that leads to using wrong local cache. Add error checks and document the restriction. Fixes: 9d033dac7d7c ("