Re: [dpdk-dev] [PATCH] gro: add UDP GRO and VXLAN UDP GRO support

2020-09-02 Thread yang_y_yi
. Either user or rte_gro_rx_prepare() provides correct l2_len etc. value. Thanks, Jiayu From: yang_y_yi Sent: Wednesday, September 2, 2020 1:58 PM To: Hu, Jiayu Cc: dev@dpdk.org; tho...@monjalon.net; yangy...@inspur.com Subject: Re:RE: Re:Re: [dpdk-dev] [PATCH] gro: add UDP GRO and VXLAN

Re: [dpdk-dev] [PATCH] gro: add UDP GRO and VXLAN UDP GRO support

2020-09-01 Thread Hu, Jiayu
To: Hu, Jiayu Cc: dev@dpdk.org; tho...@monjalon.net; yangy...@inspur.com Subject: Re:RE: Re:Re: [dpdk-dev] [PATCH] gro: add UDP GRO and VXLAN UDP GRO support Importance: High Jiayu, TCP header length is variable if there is TCP option, it is usually 20 if no TCP option, but correct value must be b

Re: [dpdk-dev] [PATCH] gro: add UDP GRO and VXLAN UDP GRO support

2020-09-01 Thread yang_y_yi
k.org; tho...@monjalon.net; yangy...@inspur.com Subject: Re:Re: [dpdk-dev] [PATCH] gro: add UDP GRO and VXLAN UDP GRO support Jiayu, BTW, after I check it again, I think udp header length check is necessary, it is actually a sanity check io order to ensure it is indeed a udp packet, gro_tcp4.c did

Re: [dpdk-dev] [PATCH] gro: add UDP GRO and VXLAN UDP GRO support

2020-09-01 Thread Hu, Jiayu
dev@dpdk.org; tho...@monjalon.net; yangy...@inspur.com Subject: Re:Re: [dpdk-dev] [PATCH] gro: add UDP GRO and VXLAN UDP GRO support Jiayu, BTW, after I check it again, I think udp header length check is necessary, it is actually a sanity check io order to ensure it is indeed a udp packet, gro_t

Re: [dpdk-dev] [PATCH] gro: add UDP GRO and VXLAN UDP GRO support

2020-09-01 Thread yang_y_yi
Jiayu, BTW, after I check it again, I think udp header length check is necessary, it is actually a sanity check io order to ensure it is indeed a udp packet, gro_tcp4.c did same thing. At 2020-09-01 14:10:41, "yang_y_yi" wrote: >At 2020-09-01 12:27:29, "Hu, Jiayu" wrote: >>Hi Yi, >> >>This pat

Re: [dpdk-dev] [PATCH] gro: add UDP GRO and VXLAN UDP GRO support

2020-08-31 Thread yang_y_yi
At 2020-09-01 12:27:29, "Hu, Jiayu" wrote: >Hi Yi, > >This patch supports UDP and VxLAN/UDP, but both are in one patch. >It's too large, and please split it into small patches. Jiayu, thank you so much for your great review , I'll send v2 to split it into two patches and fix your comments. Detai

Re: [dpdk-dev] [PATCH] gro: add UDP GRO and VXLAN UDP GRO support

2020-08-31 Thread Hu, Jiayu
Hi Yi, This patch supports UDP and VxLAN/UDP, but both are in one patch. It's too large, and please split it into small patches. Thanks, Jiayu > -Original Message- > From: yang_y...@163.com > Sent: Wednesday, July 1, 2020 2:48 PM > To: dev@dpdk.org > Cc: Hu, Jiayu ; tho...@monjalon.net;

[dpdk-dev] [PATCH] gro: add UDP GRO and VXLAN UDP GRO support

2020-06-30 Thread yang_y_yi
From: Yi Yang UDP GRO and VXLAN UDP GRO can help improve VM-to-VM UDP performance when VM is enabled UFO or GSO, GRO must be supported if GSO, UFO or VXLAN UFO is enabled , otherwise, performance gain will be hurt. With this enabled in DPDK, OVS DPDK can leverage it to improve VM-to-VM UDP perfo