Re: [dpdk-dev] [PATCH] examples: fix RSS hash function configuration

2018-06-29 Thread Ferruh Yigit
On 6/29/2018 12:55 AM, Thomas Monjalon wrote: > 20/06/2018 19:15, Ferruh Yigit: >> On 6/20/2018 6:07 PM, Dan Gora wrote: >>> Hi Ferruh, >>> >>> The documentation for rte_eth_dev_configure() should get updated as >>> well to document this requirement to strip the unsupported RSS hash >>> function bi

Re: [dpdk-dev] [PATCH] examples: fix RSS hash function configuration

2018-06-28 Thread Thomas Monjalon
20/06/2018 19:15, Ferruh Yigit: > On 6/20/2018 6:07 PM, Dan Gora wrote: > > Hi Ferruh, > > > > The documentation for rte_eth_dev_configure() should get updated as > > well to document this requirement to strip the unsupported RSS hash > > function bits. The current documentation only refers to th

Re: [dpdk-dev] [PATCH] examples: fix RSS hash function configuration

2018-06-21 Thread Ferruh Yigit
On 6/21/2018 5:54 PM, Pavan Nikhilesh wrote: > Hi Ferruh, > > On Wed, Jun 20, 2018 at 04:01:22PM +0100, Ferruh Yigit wrote: >> ethdev layer introduced checks for application requested RSS hash >> functions and returns error for ones unsupported by hardware >> >> This check breaks some sample appli

Re: [dpdk-dev] [PATCH] examples: fix RSS hash function configuration

2018-06-21 Thread Pavan Nikhilesh
Hi Ferruh, On Wed, Jun 20, 2018 at 04:01:22PM +0100, Ferruh Yigit wrote: > ethdev layer introduced checks for application requested RSS hash > functions and returns error for ones unsupported by hardware > > This check breaks some sample applications which blindly configures > RSS hash functions w

Re: [dpdk-dev] [PATCH] examples: fix RSS hash function configuration

2018-06-20 Thread Ferruh Yigit
On 6/20/2018 6:07 PM, Dan Gora wrote: > Hi Ferruh, > > The documentation for rte_eth_dev_configure() should get updated as > well to document this requirement to strip the unsupported RSS hash > function bits. The current documentation only refers to the tx/rx > offload bits: > > * - Any o

Re: [dpdk-dev] [PATCH] examples: fix RSS hash function configuration

2018-06-20 Thread Ferruh Yigit
On 6/20/2018 6:03 PM, Dan Gora wrote: > Hi Ferruh, > > Thanks for this.. I had started working on a patch to do this as well > because I got bit by this error. > > Shouldn't all of the example applications also add the code to strip > the unsupported Tx and Rx offload bits as well? It would help

Re: [dpdk-dev] [PATCH] examples: fix RSS hash function configuration

2018-06-20 Thread Dan Gora
Hi Ferruh, The documentation for rte_eth_dev_configure() should get updated as well to document this requirement to strip the unsupported RSS hash function bits. The current documentation only refers to the tx/rx offload bits: * - Any offloading set in eth_conf->[rt]xmode.offloads must be

Re: [dpdk-dev] [PATCH] examples: fix RSS hash function configuration

2018-06-20 Thread Dan Gora
Hi Ferruh, Thanks for this.. I had started working on a patch to do this as well because I got bit by this error. Shouldn't all of the example applications also add the code to strip the unsupported Tx and Rx offload bits as well? It would help new users (like me!) to understand that this is a r

Re: [dpdk-dev] [PATCH] examples: fix RSS hash function configuration

2018-06-20 Thread Hunt, David
Hi Ferruh, On 20/6/2018 4:01 PM, Ferruh Yigit wrote: ethdev layer introduced checks for application requested RSS hash functions and returns error for ones unsupported by hardware This check breaks some sample applications which blindly configures RSS hash functions without checking underlying

[dpdk-dev] [PATCH] examples: fix RSS hash function configuration

2018-06-20 Thread Ferruh Yigit
ethdev layer introduced checks for application requested RSS hash functions and returns error for ones unsupported by hardware This check breaks some sample applications which blindly configures RSS hash functions without checking underlying hardware support. Updated examples to mask out unsuppor