Re: [dpdk-dev] [PATCH] examples/vhost_scsi: drop unimplemented EVENT_IDX feature bit

2018-02-05 Thread Ferruh Yigit
On 2/1/2018 2:47 PM, Yuanhan Liu wrote: > On Wed, Jan 31, 2018 at 05:48:28PM +, Stefan Hajnoczi wrote: >> The vhost_scsi example application negotiates the >> VIRTIO_RING_F_EVENT_IDX feature bit but does not honor it when accessing >> vrings. >> >> In particular, commit e37ff954405addb8ea422426

Re: [dpdk-dev] [PATCH] examples/vhost_scsi: drop unimplemented EVENT_IDX feature bit

2018-02-01 Thread Yuanhan Liu
On Wed, Jan 31, 2018 at 05:48:28PM +, Stefan Hajnoczi wrote: > The vhost_scsi example application negotiates the > VIRTIO_RING_F_EVENT_IDX feature bit but does not honor it when accessing > vrings. > > In particular, commit e37ff954405addb8ea422426a2d162d00dcad196 ("vhost: > support virtqueue

Re: [dpdk-dev] [PATCH] examples/vhost_scsi: drop unimplemented EVENT_IDX feature bit

2018-01-31 Thread Liu, Changpeng
> -Original Message- > From: Stefan Hajnoczi [mailto:stefa...@redhat.com] > Sent: Thursday, February 1, 2018 1:48 AM > To: dev@dpdk.org > Cc: Chen, Junjie J ; Yuanhan Liu > ; > Liu, Changpeng ; Maxime Coquelin > ; Stefan Hajnoczi > Subject: [PATCH] examples/vhost_scsi: drop unimplemente

[dpdk-dev] [PATCH] examples/vhost_scsi: drop unimplemented EVENT_IDX feature bit

2018-01-31 Thread Stefan Hajnoczi
The vhost_scsi example application negotiates the VIRTIO_RING_F_EVENT_IDX feature bit but does not honor it when accessing vrings. In particular, commit e37ff954405addb8ea422426a2d162d00dcad196 ("vhost: support virtqueue interrupt/notification suppression") broke vring call because vq->last_used_i