[dpdk-dev] [PATCH] examples/ipsec-secgw: Calling risky function

2016-06-07 Thread Mrozowicz, SlawomirX
>-Original Message- >From: Gonzalez Monroy, Sergio >Sent: Tuesday, June 7, 2016 10:15 AM >To: Mrozowicz, SlawomirX >Cc: dev at dpdk.org >Subject: Re: [PATCH] examples/ipsec-secgw: Calling risky function > >On 07/06/2016 09:58, Slawomir Mrozowicz wrote: >> lrand48 should not be used for se

[dpdk-dev] [PATCH] examples/ipsec-secgw: Calling risky function

2016-06-07 Thread Slawomir Mrozowicz
lrand48 should not be used for security related applications, as linear congruential algorithms are too easy to break. Used a compliant random number generator /dev/urandom. Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application") Coverity ID 124558 Signed-off-by: Slawomir Mrozo

[dpdk-dev] [PATCH] examples/ipsec-secgw: Calling risky function

2016-06-07 Thread Thomas Monjalon
Hi Slawomir, "Calling risky function" -> it's obviously a NACK :) unless you mean "replace non-secure random".

[dpdk-dev] [PATCH] examples/ipsec-secgw: Calling risky function

2016-06-07 Thread Sergio Gonzalez Monroy
On 07/06/2016 09:58, Slawomir Mrozowicz wrote: > lrand48 should not be used for security related applications, > as linear congruential algorithms are too easy to break. > Used a compliant random number generator /dev/urandom. > > Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample applica