Re: [dpdk-dev] [PATCH] examples/ioat: fix failure check for ioat dequeue

2020-02-13 Thread David Marchand
On Tue, Feb 4, 2020 at 5:10 PM Ciara Power wrote: > > The nb_dq return value from the ioat dequeue is negative in failure > cases, however the variable was an unsigned int, causing the condition > where nb_dq <= 0 to never be true. This is now cast to a signed int, > which will successfully reflec

Re: [dpdk-dev] [PATCH] examples/ioat: fix failure check for ioat dequeue

2020-02-13 Thread Bruce Richardson
On Tue, Feb 04, 2020 at 04:00:06PM +, Ciara Power wrote: > The nb_dq return value from the ioat dequeue is negative in failure > cases, however the variable was an unsigned int, causing the condition > where nb_dq <= 0 to never be true. This is now cast to a signed int, > which will successfull

[dpdk-dev] [PATCH] examples/ioat: fix failure check for ioat dequeue

2020-02-04 Thread Ciara Power
The nb_dq return value from the ioat dequeue is negative in failure cases, however the variable was an unsigned int, causing the condition where nb_dq <= 0 to never be true. This is now cast to a signed int, which will successfully reflect the -1 value to be used in this conditional check. Coverit