Re: [dpdk-dev] [PATCH] ethdev: make default behavior CRC strip on Rx

2018-09-04 Thread Shahaf Shuler
Hi Ferruh, Monday, September 3, 2018 5:45 PM, Ferruh Yigit: > Subject: [PATCH] ethdev: make default behavior CRC strip on Rx > > Removed DEV_RX_OFFLOAD_CRC_STRIP offload flag. > Without any specific Rx offload flag, default behavior by PMDs is to > strip CRC. > > PMDs that support keeping CRC s

Re: [dpdk-dev] [PATCH] ethdev: make default behavior CRC strip on Rx

2018-09-04 Thread Tomasz Duszynski
On Mon, Sep 03, 2018 at 03:45:01PM +0100, Ferruh Yigit wrote: > Removed DEV_RX_OFFLOAD_CRC_STRIP offload flag. > Without any specific Rx offload flag, default behavior by PMDs is to > strip CRC. > > PMDs that support keeping CRC should advertise DEV_RX_OFFLOAD_KEEP_CRC > Rx offload capability. > >

Re: [dpdk-dev] [PATCH] ethdev: make default behavior CRC strip on Rx

2018-09-04 Thread Ferruh Yigit
On 9/4/2018 6:54 AM, Andrew Rybchenko wrote: > On 09/04/2018 08:17 AM, Shahaf Shuler wrote: >> Hi Ferruh, >> >> Monday, September 3, 2018 5:45 PM, Ferruh Yigit: >>> Removed DEV_RX_OFFLOAD_CRC_STRIP offload flag. >>> Without any specific Rx offload flag, default behavior by PMDs is to >>> strip CRC.

Re: [dpdk-dev] [PATCH] ethdev: make default behavior CRC strip on Rx

2018-09-03 Thread Andrew Rybchenko
On 09/04/2018 08:17 AM, Shahaf Shuler wrote: Hi Ferruh, Monday, September 3, 2018 5:45 PM, Ferruh Yigit: Removed DEV_RX_OFFLOAD_CRC_STRIP offload flag. Without any specific Rx offload flag, default behavior by PMDs is to strip CRC. PMDs that support keeping CRC should advertise DEV_RX_OFFLOAD_

Re: [dpdk-dev] [PATCH] ethdev: make default behavior CRC strip on Rx

2018-09-03 Thread Shahaf Shuler
Hi Ferruh, Monday, September 3, 2018 5:45 PM, Ferruh Yigit: > Removed DEV_RX_OFFLOAD_CRC_STRIP offload flag. > Without any specific Rx offload flag, default behavior by PMDs is to > strip CRC. > > PMDs that support keeping CRC should advertise > DEV_RX_OFFLOAD_KEEP_CRC > Rx offload capability. >

Re: [dpdk-dev] [PATCH] ethdev: make default behavior CRC strip on Rx

2018-09-03 Thread Andrew Rybchenko
On 09/03/2018 05:45 PM, Ferruh Yigit wrote: Removed DEV_RX_OFFLOAD_CRC_STRIP offload flag. Without any specific Rx offload flag, default behavior by PMDs is to strip CRC. PMDs that support keeping CRC should advertise DEV_RX_OFFLOAD_KEEP_CRC Rx offload capability. Applications that require keep

[dpdk-dev] [PATCH] ethdev: make default behavior CRC strip on Rx

2018-09-03 Thread Ferruh Yigit
Removed DEV_RX_OFFLOAD_CRC_STRIP offload flag. Without any specific Rx offload flag, default behavior by PMDs is to strip CRC. PMDs that support keeping CRC should advertise DEV_RX_OFFLOAD_KEEP_CRC Rx offload capability. Applications that require keeping CRC should check PMD capability first and