Re: [dpdk-dev] [PATCH] ethdev: keep port_id unchanged if obtaining by name failed

2017-06-09 Thread Thomas Monjalon
18/05/2017 14:19, Ilya Maximets: > Currently, 'rte_eth_dev_get_port_by_name' changes transmitted > 'port_id' unconditionally. This is undocumented and misleading > behaviour as user may expect unchanged value in case of error. > > Otherwise, there is no sense having both return value and > a point

[dpdk-dev] [PATCH] ethdev: keep port_id unchanged if obtaining by name failed

2017-05-18 Thread Ilya Maximets
Currently, 'rte_eth_dev_get_port_by_name' changes transmitted 'port_id' unconditionally. This is undocumented and misleading behaviour as user may expect unchanged value in case of error. Otherwise, there is no sense having both return value and a pointer in the function. Fixes: 9c5b8d8b9feb ("et