Re: [dpdk-dev] [PATCH] ethdev: fix rte_eth_dev_owner_unset

2018-08-24 Thread Stephen Hemminger
On Fri, 24 Aug 2018 14:55:56 +0100 Ferruh Yigit wrote: > On 8/14/2018 8:46 PM, Matan Azrad wrote: > > Hi Stephen > > > > From: Stephen Hemminger > >> On Tue, 14 Aug 2018 05:52:20 + > >> Matan Azrad wrote: > >> > >>> Hi Stephen > >>> > >>> From: Stephen Hemminger > The rte_eth_dev

Re: [dpdk-dev] [PATCH] ethdev: fix rte_eth_dev_owner_unset

2018-08-24 Thread Ferruh Yigit
On 8/14/2018 8:46 PM, Matan Azrad wrote: > Hi Stephen > > From: Stephen Hemminger >> On Tue, 14 Aug 2018 05:52:20 + >> Matan Azrad wrote: >> >>> Hi Stephen >>> >>> From: Stephen Hemminger The rte_eth_dev_owner_unset function is unusable because it always returns -EINVAL. This is bec

Re: [dpdk-dev] [PATCH] ethdev: fix rte_eth_dev_owner_unset

2018-08-14 Thread Matan Azrad
Hi Stephen From: Stephen Hemminger > On Tue, 14 Aug 2018 05:52:20 + > Matan Azrad wrote: > > > Hi Stephen > > > > From: Stephen Hemminger > > > The rte_eth_dev_owner_unset function is unusable because it always > > > returns -EINVAL. This is because the magic (unowned) value is > > > flagged

Re: [dpdk-dev] [PATCH] ethdev: fix rte_eth_dev_owner_unset

2018-08-14 Thread Stephen Hemminger
On Tue, 14 Aug 2018 05:52:20 + Matan Azrad wrote: > Hi Stephen > > From: Stephen Hemminger > > The rte_eth_dev_owner_unset function is unusable because it always > > returns -EINVAL. This is because the magic (unowned) value is flagged as not > > valid. > > > > It's OK to raise an error

Re: [dpdk-dev] [PATCH] ethdev: fix rte_eth_dev_owner_unset

2018-08-13 Thread Matan Azrad
Hi Stephen From: Stephen Hemminger > The rte_eth_dev_owner_unset function is unusable because it always > returns -EINVAL. This is because the magic (unowned) value is flagged as not > valid. > It's OK to raise an error when you do unset for unowned device. It means that unset owner should be ca

[dpdk-dev] [PATCH] ethdev: fix rte_eth_dev_owner_unset

2018-08-13 Thread Stephen Hemminger
The rte_eth_dev_owner_unset function is unusable because it always returns -EINVAL. This is because the magic (unowned) value is flagged as not valid. Move the validation of owner into set and unset as separate calls. Fixes: 5b7ba31148a8 ("ethdev: add port ownership") Signed-off-by: Stephen Hemmi