Re: [dpdk-dev] [PATCH] ethdev: fix device state on close

2017-08-18 Thread Gaëtan Rivet
On Thu, Aug 17, 2017 at 06:04:27AM +, Shahaf Shuler wrote: > Wednesday, August 16, 2017 6:26 PM, Gaëtan Rivet: > > > Even though it is reasonable for driver to call the > > rte_eth_dev_port_release, I still think the ethdev layer should protect from > > such bad behavior from the application si

Re: [dpdk-dev] [PATCH] ethdev: fix device state on close

2017-08-16 Thread Shahaf Shuler
Wednesday, August 16, 2017 6:26 PM, Gaëtan Rivet: > > Even though it is reasonable for driver to call the > rte_eth_dev_port_release, I still think the ethdev layer should protect from > such bad behavior from the application side. > > It is more robust than counting on the different PMD to impleme

Re: [dpdk-dev] [PATCH] ethdev: fix device state on close

2017-08-16 Thread Gaëtan Rivet
On Wed, Aug 16, 2017 at 02:17:16PM +, Shahaf Shuler wrote: > Wednesday, August 16, 2017 3:42 PM, Gaëtan Rivet: > > On Wed, Aug 16, 2017 at 02:43:08PM +0300, Shahaf Shuler wrote: > > > Currently device state moves between ATTACHED when device was > > > successfully probed to UNUSED when device i

Re: [dpdk-dev] [PATCH] ethdev: fix device state on close

2017-08-16 Thread Shahaf Shuler
Wednesday, August 16, 2017 3:42 PM, Gaëtan Rivet: > On Wed, Aug 16, 2017 at 02:43:08PM +0300, Shahaf Shuler wrote: > > Currently device state moves between ATTACHED when device was > > successfully probed to UNUSED when device is detached or released. > > > > The device state following rte_eth_dev_

Re: [dpdk-dev] [PATCH] ethdev: fix device state on close

2017-08-16 Thread Gaëtan Rivet
Hello Shahaf, On Wed, Aug 16, 2017 at 02:43:08PM +0300, Shahaf Shuler wrote: > Currently device state moves between ATTACHED when device was > successfully probed to UNUSED when device is detached or released. > > The device state following rte_eth_dev_close() operation is inconsist, > The device

[dpdk-dev] [PATCH] ethdev: fix device state on close

2017-08-16 Thread Shahaf Shuler
Currently device state moves between ATTACHED when device was successfully probed to UNUSED when device is detached or released. The device state following rte_eth_dev_close() operation is inconsist, The device is still in ATTACHED state, however it cannot be used in any way till it will be probed