Re: [dpdk-dev] [PATCH] ethdev: fix QinQ strip offload support

2019-04-15 Thread Rami Rosen
>Using a local (pointer) variable for dev->data->dev_conf.rxmode.offloads >would make the code more readable and lines shorter. +1

Re: [dpdk-dev] [PATCH] ethdev: fix QinQ strip offload support

2019-04-15 Thread Stephen Hemminger
On Sun, 14 Apr 2019 16:41:42 +0530 wrote: > > + cur = !!(offload_mask & ETH_QINQ_STRIP_OFFLOAD); > + org = !!(dev->data->dev_conf.rxmode.offloads & > + DEV_RX_OFFLOAD_QINQ_STRIP); > + if (cur != org) { > + if (cur) > + dev->data->dev_conf

[dpdk-dev] [PATCH] ethdev: fix QinQ strip offload support

2019-04-14 Thread viveksharma
From: Vivek Sharma Enable missing support for QinQ strip rx offload in vlan offload set/get methods. Fixes: cc9d0456b870 ("i40e: support double vlan stripping and insertion") Cc: sta...@dpdk.org Signed-off-by: Vivek Sharma --- lib/librte_ethdev/rte_ethdev.c | 17 + lib/librte_

[dpdk-dev] [PATCH] ethdev: fix QinQ strip offload support

2019-04-13 Thread Vivek Kumar Sharma
Enable missing support for QinQ strip rx offload in vlan offload set/get methods. Fixes: cc9d0456b870 ("i40e: support double vlan stripping and insertion") Cc: sta...@dpdk.org Signed-off-by: Vivek Sharma --- lib/librte_ethdev/rte_ethdev.c | 17 + lib/librte_ethdev/rte_ethdev.h |