Re: [dpdk-dev] [PATCH] ethdev: avoid undefined behaviour on configuration copying

2019-11-19 Thread Ferruh Yigit
On 11/19/2019 8:22 AM, Andrew Rybchenko wrote: > memcpy() source and destination areas must not overlap and equal > pointers is the case which is really met, so handle it. > > Fixes: 68b931bff287 ("ethdev: eliminate interim variable") > Cc: sta...@dpdk.org > > Signed-off-by: Andrew Rybchenko Re

Re: [dpdk-dev] [PATCH] ethdev: avoid undefined behaviour on configuration copying

2019-11-19 Thread Andrew Rybchenko
On 11/19/19 4:19 PM, Ferruh Yigit wrote: > On 11/19/2019 12:36 PM, Andrew Rybchenko wrote: >> On 11/19/19 3:24 PM, Ferruh Yigit wrote: >>> On 11/19/2019 8:22 AM, Andrew Rybchenko wrote: memcpy() source and destination areas must not overlap and equal pointers is the case which is really m

Re: [dpdk-dev] [PATCH] ethdev: avoid undefined behaviour on configuration copying

2019-11-19 Thread Ferruh Yigit
On 11/19/2019 12:36 PM, Andrew Rybchenko wrote: > On 11/19/19 3:24 PM, Ferruh Yigit wrote: >> On 11/19/2019 8:22 AM, Andrew Rybchenko wrote: >>> memcpy() source and destination areas must not overlap and equal >>> pointers is the case which is really met, so handle it. >> Agree providing same confi

Re: [dpdk-dev] [PATCH] ethdev: avoid undefined behaviour on configuration copying

2019-11-19 Thread Andrew Rybchenko
On 11/19/19 3:24 PM, Ferruh Yigit wrote: > On 11/19/2019 8:22 AM, Andrew Rybchenko wrote: >> memcpy() source and destination areas must not overlap and equal >> pointers is the case which is really met, so handle it. > Agree providing same config as input can cause problem with current > implementa

Re: [dpdk-dev] [PATCH] ethdev: avoid undefined behaviour on configuration copying

2019-11-19 Thread Ferruh Yigit
On 11/19/2019 8:22 AM, Andrew Rybchenko wrote: > memcpy() source and destination areas must not overlap and equal > pointers is the case which is really met, so handle it. Agree providing same config as input can cause problem with current implementation, but it is the limitation of the memcpy, th

[dpdk-dev] [PATCH] ethdev: avoid undefined behaviour on configuration copying

2019-11-19 Thread Andrew Rybchenko
memcpy() source and destination areas must not overlap and equal pointers is the case which is really met, so handle it. Fixes: 68b931bff287 ("ethdev: eliminate interim variable") Cc: sta...@dpdk.org Signed-off-by: Andrew Rybchenko --- slave_configure() in drivers/net/bonding calls rte_eth_dev_c