Re: [dpdk-dev] [PATCH] ethdev: avoid blocking telemetry callback for link status

2021-01-19 Thread Bruce Richardson
On Tue, Jan 19, 2021 at 10:58:42AM +0800, Min Hu (Connor) wrote: > Thank Stephen, > but in which the scenarios, it should wait link to up, in which > scenarios, it should not ? > By the way, how to define the "wait" time value ? > I believe the documentation somewhere refers to a wait time of up

Re: [dpdk-dev] [PATCH] ethdev: avoid blocking telemetry callback for link status

2021-01-18 Thread Min Hu (Connor)
Thank Stephen, but in which the scenarios, it should wait link to up, in which scenarios, it should not ? By the way, how to define the "wait" time value ? 在 2021/1/19 10:26, Stephen Hemminger 写道: On Tue, 19 Jan 2021 09:06:48 +0800 "Min Hu (Connor)" wrote: Hi, Bruce and all, Do you

Re: [dpdk-dev] [PATCH] ethdev: avoid blocking telemetry callback for link status

2021-01-18 Thread Stephen Hemminger
On Tue, 19 Jan 2021 09:06:48 +0800 "Min Hu (Connor)" wrote: > Hi, Bruce and all, > Do you know the difference between "rte_eth_link_get" and > "rte_eth_link_get_nowait"? I know they call funciton "link_update" > with differenct parameter "wait_to_complete"(set 1 means wait, set 0 > means

Re: [dpdk-dev] [PATCH] ethdev: avoid blocking telemetry callback for link status

2021-01-18 Thread Min Hu (Connor)
Hi, Bruce and all, Do you know the difference between "rte_eth_link_get" and "rte_eth_link_get_nowait"? I know they call funciton "link_update" with differenct parameter "wait_to_complete"(set 1 means wait, set 0 means not wait). But how to define the "wait" time, and why it shoud wait?

Re: [dpdk-dev] [PATCH] ethdev: avoid blocking telemetry callback for link status

2021-01-18 Thread Ferruh Yigit
On 1/18/2021 2:02 PM, Thomas Monjalon wrote: When querying the link status via telemetry interface, we don't want the client to have to wait for multiple seconds for a reply. Therefore use "rte_eth_link_get_nowait()" rather than "rte_eth_link_get()" in the telemetry callback. Cc: sta...@dpdk.org

Re: [dpdk-dev] [PATCH] ethdev: avoid blocking telemetry callback for link status

2021-01-18 Thread Thomas Monjalon
> >When querying the link status via telemetry interface, we don't want the > >client to have to wait for multiple seconds for a reply. Therefore use > >"rte_eth_link_get_nowait()" rather than "rte_eth_link_get()" in the telemetry > >callback. > > > >Cc: sta...@dpdk.org > >Fixes: c190daedb9b1 ("eth

Re: [dpdk-dev] [PATCH] ethdev: avoid blocking telemetry callback for link status

2021-01-14 Thread Power, Ciara
Hi Bruce, >-Original Message- >From: Richardson, Bruce >Sent: Thursday 14 January 2021 12:18 >To: dev@dpdk.org >Cc: Richardson, Bruce ; sta...@dpdk.org; >Thomas Monjalon ; Yigit, Ferruh >; Andrew Rybchenko >; Power, Ciara ; >Wiles, Keith >Subject: [PATCH] ethdev: avoid blocking telemetry

[dpdk-dev] [PATCH] ethdev: avoid blocking telemetry callback for link status

2021-01-14 Thread Bruce Richardson
When querying the link status via telemetry interface, we don't want the client to have to wait for multiple seconds for a reply. Therefore use "rte_eth_link_get_nowait()" rather than "rte_eth_link_get()" in the telemetry callback. Cc: sta...@dpdk.org Fixes: c190daedb9b1 ("ethdev: add telemetry ca