Re: [dpdk-dev] [PATCH] ethdev: add new offload flag to keep CRC

2018-06-21 Thread Shahaf Shuler
Wednesday, June 20, 2018 7:13 PM. Ferruh Yigit: > Subject: Re: [dpdk-dev] [PATCH] ethdev: add new offload flag to keep CRC > > On 6/20/2018 2:44 PM, Shahaf Shuler wrote: > > > > Hi Ferruh, > > > > Tuesday, June 19, 2018 9:03 PM, Ferruh Yigit > >> S

Re: [dpdk-dev] [PATCH] ethdev: add new offload flag to keep CRC

2018-06-20 Thread Andrew Rybchenko
On 20.06.2018 21:12, Ferruh Yigit wrote: On 6/20/2018 6:39 PM, Andrew Rybchenko wrote: On 06/20/2018 08:24 PM, Ferruh Yigit wrote: On 6/20/2018 8:42 AM, Andrew Rybchenko wrote: On 06/19/2018 09:02 PM, Ferruh Yigit wrote: DEV_RX_OFFLOAD_KEEP_CRC offload flag added. PMDs that supports keeping C

Re: [dpdk-dev] [PATCH] ethdev: add new offload flag to keep CRC

2018-06-20 Thread Ferruh Yigit
On 6/20/2018 6:39 PM, Andrew Rybchenko wrote: > On 06/20/2018 08:24 PM, Ferruh Yigit wrote: >> On 6/20/2018 8:42 AM, Andrew Rybchenko wrote: >>> On 06/19/2018 09:02 PM, Ferruh Yigit wrote: DEV_RX_OFFLOAD_KEEP_CRC offload flag added. PMDs that supports keeping CRC should advertise this off

Re: [dpdk-dev] [PATCH] ethdev: add new offload flag to keep CRC

2018-06-20 Thread Andrew Rybchenko
On 06/20/2018 08:24 PM, Ferruh Yigit wrote: On 6/20/2018 8:42 AM, Andrew Rybchenko wrote: On 06/19/2018 09:02 PM, Ferruh Yigit wrote: DEV_RX_OFFLOAD_KEEP_CRC offload flag added. PMDs that supports keeping CRC should advertise this offload capability. DEV_RX_OFFLOAD_CRC_STRIP flag will remain o

Re: [dpdk-dev] [PATCH] ethdev: add new offload flag to keep CRC

2018-06-20 Thread Ferruh Yigit
On 6/20/2018 8:42 AM, Andrew Rybchenko wrote: > On 06/19/2018 09:02 PM, Ferruh Yigit wrote: >> DEV_RX_OFFLOAD_KEEP_CRC offload flag added. PMDs that supports keeping >> CRC should advertise this offload capability. >> >> DEV_RX_OFFLOAD_CRC_STRIP flag will remain one more release >> default behavior

Re: [dpdk-dev] [PATCH] ethdev: add new offload flag to keep CRC

2018-06-20 Thread Ferruh Yigit
On 6/20/2018 2:44 PM, Shahaf Shuler wrote: > > Hi Ferruh, > > Tuesday, June 19, 2018 9:03 PM, Ferruh Yigit >> Subject: [dpdk-dev] [PATCH] ethdev: add new offload flag to keep CRC >> > > [...] > > >> diff --git a/drivers/net/mlx5/mlx5_rxq.c b/driv

Re: [dpdk-dev] [PATCH] ethdev: add new offload flag to keep CRC

2018-06-20 Thread Shahaf Shuler
Hi Ferruh, Tuesday, June 19, 2018 9:03 PM, Ferruh Yigit > Subject: [dpdk-dev] [PATCH] ethdev: add new offload flag to keep CRC > [...] > diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c > index de3f869ed..28cf168aa 100644 > --- a/drivers/net/mlx5/mlx

Re: [dpdk-dev] [PATCH] ethdev: add new offload flag to keep CRC

2018-06-20 Thread Legacy, Allain
> -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Tuesday, June 19, 2018 2:03 PM <...> > Subject: [PATCH] ethdev: add new offload flag to keep CRC > > DEV_RX_OFFLOAD_KEEP_CRC offload flag added. PMDs that supports > keeping CRC should advertise this offload

Re: [dpdk-dev] [PATCH] ethdev: add new offload flag to keep CRC

2018-06-20 Thread Andrew Rybchenko
On 06/19/2018 09:02 PM, Ferruh Yigit wrote: DEV_RX_OFFLOAD_KEEP_CRC offload flag added. PMDs that supports keeping CRC should advertise this offload capability. DEV_RX_OFFLOAD_CRC_STRIP flag will remain one more release default behavior in PMDs are to keep the CRC until this flag removed Until

[dpdk-dev] [PATCH] ethdev: add new offload flag to keep CRC

2018-06-19 Thread Ferruh Yigit
DEV_RX_OFFLOAD_KEEP_CRC offload flag added. PMDs that supports keeping CRC should advertise this offload capability. DEV_RX_OFFLOAD_CRC_STRIP flag will remain one more release default behavior in PMDs are to keep the CRC until this flag removed Until DEV_RX_OFFLOAD_CRC_STRIP flag is removed: - Se