[dpdk-dev] [PATCH] ethdev: add new RX/TX queue state arrays in rte_eth_dev_data

2015-09-17 Thread Thomas Monjalon
2015-09-16 21:22, De Lara Guarch, Pablo: > From: Ananyev, Konstantin > > Why not something like: > > ret = dev->dev_ops->tx_queue_start(dev, tx_queue_id); > > if (ret == 0) > > dev->data->tx_queue_state[tx_queue_id] = > > RTE_ETH_QUEUE_STATE_START; > > > > Same for dev_stop and RX. > > Then you

[dpdk-dev] [PATCH] ethdev: add new RX/TX queue state arrays in rte_eth_dev_data

2015-09-17 Thread De Lara Guarch, Pablo
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Thursday, September 17, 2015 8:24 AM > To: De Lara Guarch, Pablo > Cc: dev at dpdk.org; Ananyev, Konstantin > Subject: Re: [dpdk-dev] [PATCH] ethdev: add new RX/TX queue

[dpdk-dev] [PATCH] ethdev: add new RX/TX queue state arrays in rte_eth_dev_data

2015-09-16 Thread De Lara Guarch, Pablo
Hi Konstantin, > -Original Message- > From: Ananyev, Konstantin > Sent: Wednesday, September 16, 2015 5:27 PM > To: De Lara Guarch, Pablo > Cc: dev at dpdk.org > Subject: RE: [dpdk-dev] [PATCH] ethdev: add new RX/TX queue state arrays > in rte_eth_dev_data > &g

[dpdk-dev] [PATCH] ethdev: add new RX/TX queue state arrays in rte_eth_dev_data

2015-09-16 Thread Ananyev, Konstantin
Hi Pablo, Few comments from me, please see below. Konstantin > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pablo de Lara > Sent: Wednesday, September 16, 2015 12:21 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] ethdev: add new RX

[dpdk-dev] [PATCH] ethdev: add new RX/TX queue state arrays in rte_eth_dev_data

2015-09-16 Thread Pablo de Lara
Following the same approach taken with dev_started field in rte_eth_dev_data structure, this patch adds two new fields in it, rx_queue_state and tx_queue_state arrays, which track which queues have been started and which not. This is important to avoid trying to start/stop twice a queue, which wil