Re: [dpdk-dev] [PATCH] ethdev: add function name to log message

2018-10-17 Thread Ferruh Yigit
On 10/17/2018 10:26 AM, Gaëtan Rivet wrote: > Hi Ferruh, > > On Tue, Oct 16, 2018 at 04:55:43PM +0100, Ferruh Yigit wrote: >> On 10/12/2018 3:54 PM, Stephen Hemminger wrote: >>> On Fri, 12 Oct 2018 14:43:57 +0200 >>> Adrien Mazarguil wrote: >>> On Fri, Oct 12, 2018 at 11:45:01AM +0100, Ferru

Re: [dpdk-dev] [PATCH] ethdev: add function name to log message

2018-10-17 Thread Gaëtan Rivet
Hi Ferruh, On Tue, Oct 16, 2018 at 04:55:43PM +0100, Ferruh Yigit wrote: > On 10/12/2018 3:54 PM, Stephen Hemminger wrote: > > On Fri, 12 Oct 2018 14:43:57 +0200 > > Adrien Mazarguil wrote: > > > >> On Fri, Oct 12, 2018 at 11:45:01AM +0100, Ferruh Yigit wrote: > >>> On 10/12/2018 11:42 AM, Ferru

Re: [dpdk-dev] [PATCH] ethdev: add function name to log message

2018-10-16 Thread Ferruh Yigit
On 10/12/2018 3:54 PM, Stephen Hemminger wrote: > On Fri, 12 Oct 2018 14:43:57 +0200 > Adrien Mazarguil wrote: > >> On Fri, Oct 12, 2018 at 11:45:01AM +0100, Ferruh Yigit wrote: >>> On 10/12/2018 11:42 AM, Ferruh Yigit wrote: On 10/11/2018 6:59 PM, Stephen Hemminger wrote: > @@ -161,

Re: [dpdk-dev] [PATCH] ethdev: add function name to log message

2018-10-12 Thread Stephen Hemminger
On Fri, 12 Oct 2018 14:43:57 +0200 Adrien Mazarguil wrote: > On Fri, Oct 12, 2018 at 11:45:01AM +0100, Ferruh Yigit wrote: > > On 10/12/2018 11:42 AM, Ferruh Yigit wrote: > > > On 10/11/2018 6:59 PM, Stephen Hemminger wrote: > > >> @@ -161,8 +161,9 @@ extern "C" { > > >> > > >> extern int

Re: [dpdk-dev] [PATCH] ethdev: add function name to log message

2018-10-12 Thread Adrien Mazarguil
On Fri, Oct 12, 2018 at 11:45:01AM +0100, Ferruh Yigit wrote: > On 10/12/2018 11:42 AM, Ferruh Yigit wrote: > > On 10/11/2018 6:59 PM, Stephen Hemminger wrote: > >> @@ -161,8 +161,9 @@ extern "C" { > >> > >> extern int rte_eth_dev_logtype; > >> > >> -#define RTE_ETHDEV_LOG(level, ...) \ > >> -

Re: [dpdk-dev] [PATCH] ethdev: add function name to log message

2018-10-12 Thread Ferruh Yigit
On 10/12/2018 11:42 AM, Ferruh Yigit wrote: > On 10/11/2018 6:59 PM, Stephen Hemminger wrote: >> @@ -161,8 +161,9 @@ extern "C" { >> >> extern int rte_eth_dev_logtype; >> >> -#define RTE_ETHDEV_LOG(level, ...) \ >> -rte_log(RTE_LOG_ ## level, rte_eth_dev_logtype, "" __VA_ARGS__) >> +#defin

Re: [dpdk-dev] [PATCH] ethdev: add function name to log message

2018-10-12 Thread Ferruh Yigit
On 10/11/2018 6:59 PM, Stephen Hemminger wrote: > @@ -161,8 +161,9 @@ extern "C" { > > extern int rte_eth_dev_logtype; > > -#define RTE_ETHDEV_LOG(level, ...) \ > - rte_log(RTE_LOG_ ## level, rte_eth_dev_logtype, "" __VA_ARGS__) > +#define RTE_ETHDEV_LOG(level, fmt, ...) \ > +

[dpdk-dev] [PATCH] ethdev: add function name to log message

2018-10-11 Thread Stephen Hemminger
While debugging some virtio driver issues, saw: Invalid port_id=3 but it was not clear which function was logging this because the same log is being done in multiple places in ethdev. Trivial fix is to prefix with function name as is done in other drivers. Signed-off-by: Stephen Hemminger