Re: [dpdk-dev] [PATCH] ethdev: add comment to warn of ABI breakage

2020-02-18 Thread Thomas Monjalon
18/02/2020 14:13, Andrew Rybchenko: > On 2/18/20 2:59 PM, Ferruh Yigit wrote: > > On 2/18/2020 10:46 AM, Ciara Power wrote: > >> If a function is added to the eth_dev_ops struct before > >> tx_descriptor_status function, this will cause ABI breakage. This is due > >> to static inline functions usin

Re: [dpdk-dev] [PATCH] ethdev: add comment to warn of ABI breakage

2020-02-18 Thread Andrew Rybchenko
On 2/18/20 2:59 PM, Ferruh Yigit wrote: > On 2/18/2020 10:46 AM, Ciara Power wrote: >> If a function is added to the eth_dev_ops struct before >> tx_descriptor_status function, this will cause ABI breakage. This is due >> to static inline functions using this function, and some other functions >> a

Re: [dpdk-dev] [PATCH] ethdev: add comment to warn of ABI breakage

2020-02-18 Thread Ferruh Yigit
On 2/18/2020 10:46 AM, Ciara Power wrote: > If a function is added to the eth_dev_ops struct before > tx_descriptor_status function, this will cause ABI breakage. This is due > to static inline functions using this function, and some other functions > above it in the struct, so they cannot change p

[dpdk-dev] [PATCH] ethdev: add comment to warn of ABI breakage

2020-02-18 Thread Ciara Power
If a function is added to the eth_dev_ops struct before tx_descriptor_status function, this will cause ABI breakage. This is due to static inline functions using this function, and some other functions above it in the struct, so they cannot change position. A comment is added to inform developers o