Re: [dpdk-dev] [PATCH] eal: remove dead code on NUMA node detection

2019-10-24 Thread David Marchand
On Wed, Oct 23, 2019 at 7:49 PM Burakov, Anatoly wrote: > > On 22-Oct-19 8:34 PM, David Marchand wrote: > > RTE_EAL_ALLOW_INV_SOCKET_ID had been introduced and documented as used > > with xen dom0 support (dropped for some time now). > > > > Closely looking at this, the code was changed later and

Re: [dpdk-dev] [PATCH] eal: remove dead code on NUMA node detection

2019-10-23 Thread Burakov, Anatoly
On 22-Oct-19 8:34 PM, David Marchand wrote: RTE_EAL_ALLOW_INV_SOCKET_ID had been introduced and documented as used with xen dom0 support (dropped for some time now). Closely looking at this, the code was changed later and ensures that the socket id is in the [0..RTE_MAX_NUMA_NODES] range anyway.

Re: [dpdk-dev] [PATCH] eal: remove dead code on NUMA node detection

2019-10-22 Thread Stephen Hemminger
On Tue, 22 Oct 2019 21:34:17 +0200 David Marchand wrote: > RTE_EAL_ALLOW_INV_SOCKET_ID had been introduced and documented as used > with xen dom0 support (dropped for some time now). > > Closely looking at this, the code was changed later and ensures that the > socket id is in the [0..RTE_MAX_NU

[dpdk-dev] [PATCH] eal: remove dead code on NUMA node detection

2019-10-22 Thread David Marchand
RTE_EAL_ALLOW_INV_SOCKET_ID had been introduced and documented as used with xen dom0 support (dropped for some time now). Closely looking at this, the code was changed later and ensures that the socket id is in the [0..RTE_MAX_NUMA_NODES] range anyway. Let's drop this dead code and the build opti