Re: [dpdk-dev] [PATCH] eal: fix version macro

2021-03-18 Thread Bruce Richardson
On Thu, Mar 18, 2021 at 03:41:35PM +0100, Thomas Monjalon wrote: > 18/03/2021 13:28, Bruce Richardson: > > On Wed, Mar 17, 2021 at 11:01:25AM +0100, Thomas Monjalon wrote: > > > 17/03/2021 10:48, David Marchand: > > > > On Wed, Mar 17, 2021 at 10:31 AM Thomas Monjalon > > > > wrote: > > > > > > >

Re: [dpdk-dev] [PATCH] eal: fix version macro

2021-03-18 Thread Thomas Monjalon
18/03/2021 13:28, Bruce Richardson: > On Wed, Mar 17, 2021 at 11:01:25AM +0100, Thomas Monjalon wrote: > > 17/03/2021 10:48, David Marchand: > > > On Wed, Mar 17, 2021 at 10:31 AM Thomas Monjalon > > > wrote: > > > > > > > > The macro RTE_VERSION is broken since updated with function calls. > > >

Re: [dpdk-dev] [PATCH] eal: fix version macro

2021-03-18 Thread Bruce Richardson
On Wed, Mar 17, 2021 at 11:01:25AM +0100, Thomas Monjalon wrote: > 17/03/2021 10:48, David Marchand: > > On Wed, Mar 17, 2021 at 10:31 AM Thomas Monjalon > > wrote: > > > > > > The macro RTE_VERSION is broken since updated with function calls. > > > It is a build-time version number, and must be

Re: [dpdk-dev] [PATCH] eal: fix version macro

2021-03-17 Thread Thomas Monjalon
17/03/2021 16:36, David Marchand: > On Wed, Mar 17, 2021 at 10:31 AM Thomas Monjalon wrote: > > > > The macro RTE_VERSION is broken since updated with function calls. > > It is a build-time version number, and must be built with macros. > > For a run-time version number, there is the function rte_

Re: [dpdk-dev] [PATCH] eal: fix version macro

2021-03-17 Thread David Marchand
On Wed, Mar 17, 2021 at 10:31 AM Thomas Monjalon wrote: > > The macro RTE_VERSION is broken since updated with function calls. > It is a build-time version number, and must be built with macros. > For a run-time version number, there is the function rte_version(). > > Fixes: 5b637a848195 ("eal: fi

Re: [dpdk-dev] [PATCH] eal: fix version macro

2021-03-17 Thread Thomas Monjalon
17/03/2021 10:48, David Marchand: > On Wed, Mar 17, 2021 at 10:31 AM Thomas Monjalon wrote: > > > > The macro RTE_VERSION is broken since updated with function calls. > > It is a build-time version number, and must be built with macros. > > For a run-time version number, there is the function rte_

Re: [dpdk-dev] [PATCH] eal: fix version macro

2021-03-17 Thread David Marchand
On Wed, Mar 17, 2021 at 10:31 AM Thomas Monjalon wrote: > > The macro RTE_VERSION is broken since updated with function calls. > It is a build-time version number, and must be built with macros. > For a run-time version number, there is the function rte_version(). > > Fixes: 5b637a848195 ("eal: fi

[dpdk-dev] [PATCH] eal: fix version macro

2021-03-17 Thread Thomas Monjalon
The macro RTE_VERSION is broken since updated with function calls. It is a build-time version number, and must be built with macros. For a run-time version number, there is the function rte_version(). Fixes: 5b637a848195 ("eal: fix querying DPDK version at runtime") Cc: sta...@dpdk.org Reported-b