Re: [dpdk-dev] [PATCH] eal: fix telemetry logtype registration

2021-04-08 Thread David Marchand
On Tue, Apr 6, 2021 at 12:18 PM Bruce Richardson wrote: > > On Tue, Apr 06, 2021 at 11:25:45AM +0200, David Marchand wrote: > > rte_log_register_type_and_pick_level() returns an int. > > Casting to a uin32_t will make us miss the -1 passed in case of failure. > > > > Fixes: 37b881a96194 ("telemetr

Re: [dpdk-dev] [PATCH] eal: fix telemetry logtype registration

2021-04-06 Thread Thomas Monjalon
06/04/2021 12:18, Bruce Richardson: > On Tue, Apr 06, 2021 at 11:25:45AM +0200, David Marchand wrote: > > rte_log_register_type_and_pick_level() returns an int. > > Casting to a uin32_t will make us miss the -1 passed in case of failure. > > > > Fixes: 37b881a96194 ("telemetry: use log function fr

Re: [dpdk-dev] [PATCH] eal: fix telemetry logtype registration

2021-04-06 Thread Bruce Richardson
On Tue, Apr 06, 2021 at 11:25:45AM +0200, David Marchand wrote: > rte_log_register_type_and_pick_level() returns an int. > Casting to a uin32_t will make us miss the -1 passed in case of failure. > > Fixes: 37b881a96194 ("telemetry: use log function from pointer") > > Signed-off-by: David Marchan

[dpdk-dev] [PATCH] eal: fix telemetry logtype registration

2021-04-06 Thread David Marchand
rte_log_register_type_and_pick_level() returns an int. Casting to a uin32_t will make us miss the -1 passed in case of failure. Fixes: 37b881a96194 ("telemetry: use log function from pointer") Signed-off-by: David Marchand --- lib/librte_eal/freebsd/eal.c | 4 +++- lib/librte_eal/linux/eal.c