Re: [dpdk-dev] [PATCH] eal: fix compilation without VFIO

2018-04-16 Thread Burakov, Anatoly
On 16-Apr-18 6:50 AM, Shahaf Shuler wrote: Friday, April 13, 2018 4:59 PM, Thomas Monjalon: OK. Shahaf, will you submit a v2 with this, or should i do it? I think it should be just a matter of #ifndef VFIO_PRESENT //define vfio_device_info struct #endif - this should take care of the problem of

Re: [dpdk-dev] [PATCH] eal: fix compilation without VFIO

2018-04-15 Thread Shahaf Shuler
Friday, April 13, 2018 4:59 PM, Thomas Monjalon: > > > > OK. Shahaf, will you submit a v2 with this, or should i do it? I think > > it should be just a matter of #ifndef VFIO_PRESENT //define > > vfio_device_info struct #endif - this should take care of the problem > > of hiding the function defini

Re: [dpdk-dev] [PATCH] eal: fix compilation without VFIO

2018-04-13 Thread Thomas Monjalon
13/04/2018 15:37, Burakov, Anatoly: > On 13-Apr-18 2:08 PM, Thomas Monjalon wrote: > > 13/04/2018 11:11, Burakov, Anatoly: > >> On 13-Apr-18 12:39 AM, Thomas Monjalon wrote: > >>> 12/04/2018 16:13, Burakov, Anatoly: > On 12-Apr-18 2:34 PM, Shahaf Shuler wrote: > > a compilation error occur

Re: [dpdk-dev] [PATCH] eal: fix compilation without VFIO

2018-04-13 Thread Burakov, Anatoly
On 13-Apr-18 2:08 PM, Thomas Monjalon wrote: 13/04/2018 11:11, Burakov, Anatoly: On 13-Apr-18 12:39 AM, Thomas Monjalon wrote: 12/04/2018 16:13, Burakov, Anatoly: On 12-Apr-18 2:34 PM, Shahaf Shuler wrote: a compilation error occurred when compiling with CONFIG_RTE_EAL_VFIO=n == Build lib/li

Re: [dpdk-dev] [PATCH] eal: fix compilation without VFIO

2018-04-13 Thread Thomas Monjalon
13/04/2018 11:11, Burakov, Anatoly: > On 13-Apr-18 12:39 AM, Thomas Monjalon wrote: > > 12/04/2018 16:13, Burakov, Anatoly: > >> On 12-Apr-18 2:34 PM, Shahaf Shuler wrote: > >>> a compilation error occurred when compiling with CONFIG_RTE_EAL_VFIO=n > >>> > >>> == Build lib/librte_eal/linuxapp/eal >

Re: [dpdk-dev] [PATCH] eal: fix compilation without VFIO

2018-04-13 Thread Burakov, Anatoly
On 13-Apr-18 12:39 AM, Thomas Monjalon wrote: 12/04/2018 16:13, Burakov, Anatoly: On 12-Apr-18 2:34 PM, Shahaf Shuler wrote: a compilation error occurred when compiling with CONFIG_RTE_EAL_VFIO=n == Build lib/librte_eal/linuxapp/eal CC eal_vfio.o /download/dpdk/lib/librte_eal/linuxapp/eal/

Re: [dpdk-dev] [PATCH] eal: fix compilation without VFIO

2018-04-12 Thread Thomas Monjalon
12/04/2018 16:13, Burakov, Anatoly: > On 12-Apr-18 2:34 PM, Shahaf Shuler wrote: > > a compilation error occurred when compiling with CONFIG_RTE_EAL_VFIO=n > > > > == Build lib/librte_eal/linuxapp/eal > >CC eal_vfio.o > > /download/dpdk/lib/librte_eal/linuxapp/eal/eal_vfio.c:1535:1: error: no

Re: [dpdk-dev] [PATCH] eal: fix compilation without VFIO

2018-04-12 Thread Burakov, Anatoly
On 12-Apr-18 2:34 PM, Shahaf Shuler wrote: a compilation error occurred when compiling with CONFIG_RTE_EAL_VFIO=n == Build lib/librte_eal/linuxapp/eal CC eal_vfio.o /download/dpdk/lib/librte_eal/linuxapp/eal/eal_vfio.c:1535:1: error: no previous prototype for 'rte_vfio_dma_map' [-Werror=missi

[dpdk-dev] [PATCH] eal: fix compilation without VFIO

2018-04-12 Thread Shahaf Shuler
a compilation error occurred when compiling with CONFIG_RTE_EAL_VFIO=n == Build lib/librte_eal/linuxapp/eal CC eal_vfio.o /download/dpdk/lib/librte_eal/linuxapp/eal/eal_vfio.c:1535:1: error: no previous prototype for 'rte_vfio_dma_map' [-Werror=missing-prototypes] rte_vfio_dma_map(uint64_t __rt