04/09/2017 15:02, Bruce Richardson:
> Couple of other comments on this code area that should be taken into
> account:
> 1. the indentation of the asm code looks wrong, and should probably be
>fixed to make it more readable.
> 2. the comment on the "D" register is wrong as it refers to ebx
> 3.
+Correct email for Thomas.
On Mon, Sep 04, 2017 at 02:02:05PM +0100, Bruce Richardson wrote:
> On Fri, Feb 10, 2017 at 11:53:06AM +0100, Thomas Monjalon wrote:
> > 2017-02-10 10:39, Hunt, David:
> > >
> > > On 9/2/2017 4:53 PM, Thomas Monjalon wrote:
> > > > 2016-11-06 22:09, Thomas Monjalon:
> >
On Fri, Feb 10, 2017 at 11:53:06AM +0100, Thomas Monjalon wrote:
> 2017-02-10 10:39, Hunt, David:
> >
> > On 9/2/2017 4:53 PM, Thomas Monjalon wrote:
> > > 2016-11-06 22:09, Thomas Monjalon:
> > >> 2016-09-29 18:34, Thomas Monjalon:
> > >>> 2016-09-30 02:54, Nikhil Rao:
> > The original code
2017-02-10 08:46, Stephen Hemminger:
> On Fri, 10 Feb 2017 11:53:06 +0100
> Thomas Monjalon wrote:
>
> > 2017-02-10 10:39, Hunt, David:
> > >
> > > On 9/2/2017 4:53 PM, Thomas Monjalon wrote:
> > > > 2016-11-06 22:09, Thomas Monjalon:
> > > >> 2016-09-29 18:34, Thomas Monjalon:
> > > >>> 2
On Fri, 10 Feb 2017 11:53:06 +0100
Thomas Monjalon wrote:
> 2017-02-10 10:39, Hunt, David:
> >
> > On 9/2/2017 4:53 PM, Thomas Monjalon wrote:
> > > 2016-11-06 22:09, Thomas Monjalon:
> > >> 2016-09-29 18:34, Thomas Monjalon:
> > >>> 2016-09-30 02:54, Nikhil Rao:
> > The original co
On 10/2/2017 10:53 AM, Thomas Monjalon wrote:
2017-02-10 10:39, Hunt, David:
On 9/2/2017 4:53 PM, Thomas Monjalon wrote:
2016-11-06 22:09, Thomas Monjalon:
2016-09-29 18:34, Thomas Monjalon:
2016-09-30 02:54, Nikhil Rao:
The original code used movl instead of xchgl, this caused
rte_atomic6
2017-02-10 10:39, Hunt, David:
>
> On 9/2/2017 4:53 PM, Thomas Monjalon wrote:
> > 2016-11-06 22:09, Thomas Monjalon:
> >> 2016-09-29 18:34, Thomas Monjalon:
> >>> 2016-09-30 02:54, Nikhil Rao:
> The original code used movl instead of xchgl, this caused
> rte_atomic64_cmpset to use ebx a
On 9/2/2017 4:53 PM, Thomas Monjalon wrote:
2016-11-06 22:09, Thomas Monjalon:
2016-09-29 18:34, Thomas Monjalon:
2016-09-30 02:54, Nikhil Rao:
The original code used movl instead of xchgl, this caused
rte_atomic64_cmpset to use ebx as the lower dword of the source
to cmpxchg8b instead of the
2016-11-06 22:09, Thomas Monjalon:
> 2016-09-29 18:34, Thomas Monjalon:
> > 2016-09-30 02:54, Nikhil Rao:
> > > The original code used movl instead of xchgl, this caused
> > > rte_atomic64_cmpset to use ebx as the lower dword of the source
> > > to cmpxchg8b instead of the lower dword of function a
2016-09-29 18:34, Thomas Monjalon:
> 2016-09-30 02:54, Nikhil Rao:
> > The original code used movl instead of xchgl, this caused
> > rte_atomic64_cmpset to use ebx as the lower dword of the source
> > to cmpxchg8b instead of the lower dword of function argument "src".
>
> Could you please start th
The original code used movl instead of xchgl, this caused
rte_atomic64_cmpset to use ebx as the lower dword of the source
to cmpxchg8b instead of the lower dword of function argument "src".
Reported-by: Job Abraham
Tested-by: Job Abraham
Signed-off-by: Nikhil Rao
---
lib/librte_eal/common/incl
On 9/29/2016 6:35 PM, Christian Ehrhardt wrote:
> The patch misses a fixed: line which it should get I think.
The bug has existed from the day the DPDK was open-sourced, i.e, there wasn't a
specific
commit that introduced this feature/bug, hence wasn't sure if it needed the
fixes tag.
>
> Bu
2016-09-30 02:54, Nikhil Rao:
> The original code used movl instead of xchgl, this caused
> rte_atomic64_cmpset to use ebx as the lower dword of the source
> to cmpxchg8b instead of the lower dword of function argument "src".
Could you please start the explanation with a statement of
what is wrong
2016-09-29 18:46, Rao, Nikhil:
>
> On 9/29/2016 6:35 PM, Christian Ehrhardt wrote:
> > The patch misses a fixed: line which it should get I think.
>
> The bug has existed from the day the DPDK was open-sourced, i.e, there wasn't
> a specific
> commit that introduced this feature/bug, hence wasn'
The patch misses a fixed: line which it should get I think.
But in general If applied -> stable for this one?
On Thu, Sep 29, 2016 at 11:24 PM, Nikhil Rao wrote:
> The original code used movl instead of xchgl, this caused
> rte_atomic64_cmpset to use ebx as the lower dword of the source
> to c
15 matches
Mail list logo
