Re: [dpdk-dev] [PATCH] eal/windows: vfprintf build warning with clang

2020-11-28 Thread Nick Connolly
Looks good to me! On 28/11/2020 21:11, Dmitry Kozlyuk wrote: On Fri, 27 Nov 2020 12:07:11 +, Nick Connolly wrote: [...] +#ifdef __clang__ +#pragma clang diagnostic push +#pragma clang diagnostic ignored "-Wformat-nonliteral" +#endif [...] How about a more safe approach? diff --git a/lib/l

Re: [dpdk-dev] [PATCH] eal/windows: vfprintf build warning with clang

2020-11-28 Thread Dmitry Kozlyuk
On Fri, 27 Nov 2020 12:07:11 +, Nick Connolly wrote: > [...] > +#ifdef __clang__ > +#pragma clang diagnostic push > +#pragma clang diagnostic ignored "-Wformat-nonliteral" > +#endif > [...] How about a more safe approach? diff --git a/lib/librte_eal/windows/eal_lcore.c b/lib/librte_eal/windo

[dpdk-dev] [PATCH] eal/windows: vfprintf build warning with clang

2020-11-27 Thread Nick Connolly
When building with clang (11.0,--buildtype=debug), eal_lcore.c produces a -Wformat-nonliteral warning from the vfprintf call in log_early. Disable the warning for log_early when building with clang. MinGW does not seem to detect the warning. Fixes: b8a36b086625 ("eal/windows: improve CPU and NUMA