Re: [dpdk-dev] [PATCH] eal/windows: refine public interface

2020-02-04 Thread Dmitry Kozlyuk
> I agree bloating rte_os.h is a concern. > If you can achieve the initial goal (no specific include in apps, libs > and drivers) while reducing rte_os.h, I think it is good. would be such a specific include, like in Linux EAL. This file would include Windows platform SDK files in the right orde

Re: [dpdk-dev] [PATCH] eal/windows: refine public interface

2020-02-04 Thread Thomas Monjalon
31/01/2020 06:24, Dmitry Kozlyuk: > The goal of rte_os.h is to mitigate OS differences for EAL users. > In Windows EAL, rte_os.h did excessive things: That's an interesting point of view. The idea of rte_os.h was to hide OS-specifics, so the DPDK applications have no Windows-specific header to inc

[dpdk-dev] [PATCH] eal/windows: refine public interface

2020-01-30 Thread Dmitry Kozlyuk
The goal of rte_os.h is to mitigate OS differences for EAL users. In Windows EAL, rte_os.h did excessive things: 1. It included platform SDK headers (windows.h, etc). Those files are huge, require specific inclusion order, and are generally unused by the code including rte_os.h. Declarations