Re: [dpdk-dev] [PATCH] eal/windows: fix link error with MinGW

2020-11-21 Thread Dmitry Kozlyuk
On Fri, 20 Nov 2020 21:12:55 +, Nick Connolly wrote: > Linking with the 'pci' driver when building with MinGW on > Windows fails with undefined symbol 'GUID_DEVCLASS_NET'. > This occurs because devguid.h is included in rte_windows.h > before INITGUID is defined. > > Resolved by moving the incl

Re: [dpdk-dev] [PATCH] eal/windows: fix link error with MinGW

2020-11-21 Thread Nick Connolly
Hi Dmitry, On 21/11/2020 20:47, Dmitry Kozlyuk wrote: I disagree. Just because we have rte_windows.h to properly plug Windows SDK in, other DPDK code doesn't need to care about these details. Unused GUIDs do take some space in static libraries, but IMO it's a fair trade for ease of development.

Re: [dpdk-dev] [PATCH] eal/windows: fix link error with MinGW

2020-11-21 Thread Dmitry Kozlyuk
Hi Nick, Thanks for detailed explanation. It can be reproduced even without DPDK: #include #include int main(int argc, char **argv) { return (int)&GUID_DEVCLASS_NET; } This links with clang, but not with MinGW-w64. AFAIK, it should not link, because INITGUID is not defined. @DmitryM, @Nat

Re: [dpdk-dev] [PATCH] eal/windows: fix link error with MinGW

2020-11-20 Thread Nick Connolly
Build OS is Windows 10 2004

Re: [dpdk-dev] [PATCH] eal/windows: fix link error with MinGW

2020-11-20 Thread Nick Connolly
I can't seem to reproduce the link error you've mentioned (I'm building hello_world on master). can you share more information on how to reproduce it? (MinGW version, build env variables, build OS). Thanks, Tal. Hi Tal, Sure - latest MinGW-w64 (v8.0.0 I believe, but the versioning isn't

Re: [dpdk-dev] [PATCH] eal/windows: fix link error with MinGW

2020-11-20 Thread Tal Shnaiderman
> Subject: [PATCH] eal/windows: fix link error with MinGW > > Linking with the 'pci' driver when building with MinGW on Windows fails with > undefined symbol 'GUID_DEVCLASS_NET'. > This occurs because devguid.h is included in rte_windows.h before INITGUID > is defined. > Hi Nick, I can't seem

[dpdk-dev] [PATCH] eal/windows: fix link error with MinGW

2020-11-20 Thread Nick Connolly
Linking with the 'pci' driver when building with MinGW on Windows fails with undefined symbol 'GUID_DEVCLASS_NET'. This occurs because devguid.h is included in rte_windows.h before INITGUID is defined. Resolved by moving the include of devguid.h after the definition of INITGUID. Fixes: b762221ac2