Re: [dpdk-dev] [PATCH] eal/windows: detect insufficient privileges for hugepages

2020-07-08 Thread Dmitry Kozlyuk
On Wed, 8 Jul 2020 06:43:57 +, Tal Shnaiderman wrote: [snip] Thanks for the testing. > Do you think this is enough or do we want to give the user further indication > that configuration action from his side might be needed? Something alike > "Please verify OS Large-Page support is enabled f

Re: [dpdk-dev] [PATCH] eal/windows: detect insufficient privileges for hugepages

2020-07-07 Thread Tal Shnaiderman
> Subject: Re: [PATCH] eal/windows: detect insufficient privileges for > hugepages > > On Tue, 7 Jul 2020 16:45:07 -0700, Ranjit Menon wrote: > > On 7/7/2020 1:22 PM, Dmitry Kozlyuk wrote: > > > AdjustTokenPrivileges() succeeds even if no requested privileges > > > have been granted; this behavior

Re: [dpdk-dev] [PATCH] eal/windows: detect insufficient privileges for hugepages

2020-07-07 Thread Dmitry Kozlyuk
On Tue, 7 Jul 2020 16:45:07 -0700, Ranjit Menon wrote: > On 7/7/2020 1:22 PM, Dmitry Kozlyuk wrote: > > AdjustTokenPrivileges() succeeds even if no requested privileges have > > been granted; this behavior is documented. Check last error code in > > addition to return value to detect such case. > >

Re: [dpdk-dev] [PATCH] eal/windows: detect insufficient privileges for hugepages

2020-07-07 Thread Ranjit Menon
On 7/7/2020 1:22 PM, Dmitry Kozlyuk wrote: AdjustTokenPrivileges() succeeds even if no requested privileges have been granted; this behavior is documented. Check last error code in addition to return value to detect such case. Signed-off-by: Dmitry Kozlyuk --- lib/librte_eal/windows/eal_hug

[dpdk-dev] [PATCH] eal/windows: detect insufficient privileges for hugepages

2020-07-07 Thread Dmitry Kozlyuk
AdjustTokenPrivileges() succeeds even if no requested privileges have been granted; this behavior is documented. Check last error code in addition to return value to detect such case. Signed-off-by: Dmitry Kozlyuk --- lib/librte_eal/windows/eal_hugepages.c | 4 1 file changed, 4 insertions(