Re: [dpdk-dev] [PATCH] eal/reciprocal: fix off by one when divisor is 32bit

2019-10-26 Thread David Marchand
On Tue, Sep 3, 2019 at 9:17 PM wrote: > > From: Pavan Nikhilesh > > Fix off by one error in 64bit reciprocal division when divisor is 32bit. Added log from unit test: RTE>>reciprocal_division Validating unsigned 32bit division. Validating unsigned 64bit division. Validating unsi

Re: [dpdk-dev] [PATCH] eal/reciprocal: fix off by one when divisor is 32bit

2019-10-23 Thread Pavan Nikhilesh Bhagavatula
>Pavan Nikhilesh Bhagavatula writes: > >>>Pavan Nikhilesh Bhagavatula writes: >>> >> > >> >Any review? >> > >> >Are we missing an update in the unit test to catch this issue? >> >Thanks. >> >> We actually caught it in a unit test >> >test_reciprocal_division >

Re: [dpdk-dev] [PATCH] eal/reciprocal: fix off by one when divisor is 32bit

2019-10-23 Thread Aaron Conole
Pavan Nikhilesh Bhagavatula writes: >>Pavan Nikhilesh Bhagavatula writes: >> > > > >Any review? > > > >Are we missing an update in the unit test to catch this issue? > >Thanks. > > We actually caught it in a unit test > >test_reciprocal_division We had th

Re: [dpdk-dev] [PATCH] eal/reciprocal: fix off by one when divisor is 32bit

2019-10-23 Thread Pavan Nikhilesh Bhagavatula
>Pavan Nikhilesh Bhagavatula writes: > > >Any review? > >Are we missing an update in the unit test to catch this issue? >Thanks. We actually caught it in a unit test >test_reciprocal_division >>> >>>We had this problem since the very start then. >>> >>>Both

Re: [dpdk-dev] [PATCH] eal/reciprocal: fix off by one when divisor is 32bit

2019-10-23 Thread Aaron Conole
Pavan Nikhilesh Bhagavatula writes: >>> > >>> >Any review? >>> > >>> >Are we missing an update in the unit test to catch this issue? >>> >Thanks. >>> >>> We actually caught it in a unit test >>> >test_reciprocal_division >> >>We had this problem since the very start then. >> >>Both reciprocal_div

Re: [dpdk-dev] [PATCH] eal/reciprocal: fix off by one when divisor is 32bit

2019-10-23 Thread Pavan Nikhilesh Bhagavatula
>> > >> >Any review? >> > >> >Are we missing an update in the unit test to catch this issue? >> >Thanks. >> >> We actually caught it in a unit test >> >test_reciprocal_division > >We had this problem since the very start then. > >Both reciprocal_division and reciprocal_division_perf are in the "per

Re: [dpdk-dev] [PATCH] eal/reciprocal: fix off by one when divisor is 32bit

2019-10-15 Thread David Marchand
On Tue, Sep 3, 2019 at 9:17 PM wrote: > > From: Pavan Nikhilesh > > Fix off by one error in 64bit reciprocal division when divisor is 32bit. > > Fixes: 6d45659eacb8 ("eal: add u64-bit variant for reciprocal divide") > Cc: sta...@dpdk.org > > Signed-off-by: Pavan Nikhilesh Any review? Are we mi

[dpdk-dev] [PATCH] eal/reciprocal: fix off by one when divisor is 32bit

2019-09-03 Thread pbhagavatula
From: Pavan Nikhilesh Fix off by one error in 64bit reciprocal division when divisor is 32bit. Fixes: 6d45659eacb8 ("eal: add u64-bit variant for reciprocal divide") Cc: sta...@dpdk.org Signed-off-by: Pavan Nikhilesh --- Example: Division failed, 17358247066007716387/244 =