Re: [dpdk-dev] [PATCH] eal/linux: fix build when VFIO is disabled

2020-01-19 Thread Thomas Monjalon
11/12/2019 19:25, Ali Alnubani: > The header linux/version.h isn't included when CONFIG_RTE_EAL_VFIO > is explicitly disabled. LINUX_VERSION_CODE and KERNEL_VERSION are > therefore undefined, causing the build failure: > > lib/librte_eal/linux/eal/eal.c: In function ‘rte_eal_init’: > lib/librt

Re: [dpdk-dev] [PATCH] eal/linux: fix build when VFIO is disabled

2019-12-22 Thread Ali Alnubani
> -Original Message- > From: David Marchand > Sent: Monday, December 16, 2019 7:22 PM > To: Ali Alnubani > Cc: dev@dpdk.org; vattun...@marvell.com; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] eal/linux: fix build when VFIO is disabled > > On Wed, Dec

Re: [dpdk-dev] [PATCH] eal/linux: fix build when VFIO is disabled

2019-12-16 Thread David Marchand
On Wed, Dec 11, 2019 at 7:26 PM Ali Alnubani wrote: > The header linux/version.h isn't included when CONFIG_RTE_EAL_VFIO > is explicitly disabled. LINUX_VERSION_CODE and KERNEL_VERSION are > therefore undefined, causing the build failure: > > lib/librte_eal/linux/eal/eal.c: In function ‘rte_eal_

[dpdk-dev] [PATCH] eal/linux: fix build when VFIO is disabled

2019-12-11 Thread Ali Alnubani
The header linux/version.h isn't included when CONFIG_RTE_EAL_VFIO is explicitly disabled. LINUX_VERSION_CODE and KERNEL_VERSION are therefore undefined, causing the build failure: lib/librte_eal/linux/eal/eal.c: In function ‘rte_eal_init’: lib/librte_eal/linux/eal/eal.c:1076:32: error: "LINUX

Re: [dpdk-dev] [PATCH] eal/linux: fix build error on RHEL 7.6

2019-12-04 Thread Stephen Hemminger
On Wed, 4 Dec 2019 16:00:02 +0100 David Marchand wrote: > Previous fix gives hiccups to gcc on RHEL 7.6: > > == Build lib/librte_eal/linux/eal > CC eal_interrupts.o > ...lib/librte_eal/linux/eal/eal_interrupts.c: In function > ‘eal_intr_thread_main’: > ...lib/librte_eal/linux/eal/eal_interr

Re: [dpdk-dev] [PATCH] eal/linux: fix build error on RHEL 7.6

2019-12-04 Thread David Marchand
On Wed, Dec 4, 2019 at 4:37 PM Stephen Hemminger wrote: > > On Wed, 4 Dec 2019 16:00:02 +0100 > David Marchand wrote: > > > + struct epoll_event ev; > This needs to be initialized (like it was above) or it will cause > warnings with valgrind about uninitialized data in syste

Re: [dpdk-dev] [PATCH] eal/linux: fix build error on RHEL 7.6

2019-12-04 Thread Stephen Hemminger
On Wed, 4 Dec 2019 16:00:02 +0100 David Marchand wrote: > + struct epoll_event ev; This needs to be initialized (like it was above) or it will cause warnings with valgrind about uninitialized data in system calls.

[dpdk-dev] [PATCH] eal/linux: fix build error on RHEL 7.6

2019-12-04 Thread David Marchand
Previous fix gives hiccups to gcc on RHEL 7.6: == Build lib/librte_eal/linux/eal CC eal_interrupts.o ...lib/librte_eal/linux/eal/eal_interrupts.c: In function ‘eal_intr_thread_main’: ...lib/librte_eal/linux/eal/eal_interrupts.c:1048:9: error: missing initializer for field ‘events’ of ‘struct

Re: [dpdk-dev] [PATCH] eal/linux: fix build with glibc 2.25

2017-04-04 Thread Thomas Monjalon
2017-04-03 14:05, Jerin Jacob: > glibc 2.25 is warning about if applications depend on > sys/types.h for makedev macro, it expects to be included > from > > Found this error while testing with GCC 6.3.1 on archlinux. > > lib/librte_eal/linuxapp/eal/eal_pci_uio.c: In function ‘pci_mknod_uio_dev’:

[dpdk-dev] [PATCH] eal/linux: fix build with glibc 2.25

2017-04-03 Thread Jerin Jacob
glibc 2.25 is warning about if applications depend on sys/types.h for makedev macro, it expects to be included from Found this error while testing with GCC 6.3.1 on archlinux. lib/librte_eal/linuxapp/eal/eal_pci_uio.c: In function ‘pci_mknod_uio_dev’: lib/librte_eal/linuxapp/eal/eal_pci_uio.c:13

[dpdk-dev] [PATCH] eal/linux: fix build with glibc < 2.12

2016-06-20 Thread Thomas Monjalon
2016-06-19 23:11, Thomas Monjalon: > The function rte_thread_setname needs glibc 2.12, > otherwise it returns -1 without using any parameter. > The macro RTE_SET_USED avoids an "unused parameter" warning. > > Fixes: 3901ed99c2f8 ("eal: fix thread naming on FreeBSD") > > Signed-off-by: Thomas Monj

[dpdk-dev] [PATCH] eal/linux: fix build with glibc < 2.12

2016-06-19 Thread Thomas Monjalon
The function rte_thread_setname needs glibc 2.12, otherwise it returns -1 without using any parameter. The macro RTE_SET_USED avoids an "unused parameter" warning. Fixes: 3901ed99c2f8 ("eal: fix thread naming on FreeBSD") Signed-off-by: Thomas Monjalon --- lib/librte_eal/linuxapp/eal/eal_thread

[dpdk-dev] [PATCH] eal/linux: fix build

2015-03-05 Thread Thomas Monjalon
Hi Michael, 2015-03-05 09:13, Qiu, Michael: > On 3/4/2015 6:24 AM, Thomas Monjalon wrote: > >>> Compilation fails in some distributions because of missing unistd.h > >>> needed for pread/pwrite (seen with Suse): > >>> lib/librte_eal/linuxapp/eal/eal_pci_uio.c:62:2: > >>> error: imp

[dpdk-dev] [PATCH] eal/linux: fix build

2015-03-05 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Qiu, Michael > Sent: Thursday, March 05, 2015 9:13 AM > To: Thomas Monjalon; David Marchand > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] eal/linux: fix build > > On

[dpdk-dev] [PATCH] eal/linux: fix build

2015-03-05 Thread Qiu, Michael
On 3/4/2015 6:24 AM, Thomas Monjalon wrote: >>> Compilation fails in some distributions because of missing unistd.h >>> needed for pread/pwrite (seen with Suse): >>> lib/librte_eal/linuxapp/eal/eal_pci_uio.c:62:2: >>> error: implicit declaration of function ?pread? >>> >>> Fixes: 4a

[dpdk-dev] [PATCH] eal/linux: fix build

2015-03-03 Thread Thomas Monjalon
> > Compilation fails in some distributions because of missing unistd.h > > needed for pread/pwrite (seen with Suse): > > lib/librte_eal/linuxapp/eal/eal_pci_uio.c:62:2: > > error: implicit declaration of function ?pread? > > > > Fixes: 4a499c649590 ("eal/linux: enable uio_pci_gener

[dpdk-dev] [PATCH] eal/linux: fix build

2015-03-03 Thread David Marchand
On Tue, Mar 3, 2015 at 9:44 AM, Thomas Monjalon wrote: > Compilation fails in some distributions because of missing unistd.h > needed for pread/pwrite (seen with Suse): > lib/librte_eal/linuxapp/eal/eal_pci_uio.c:62:2: > error: implicit declaration of function ?pread? > > Fixes: 4

[dpdk-dev] [PATCH] eal/linux: fix build

2015-03-03 Thread Thomas Monjalon
Compilation fails in some distributions because of missing unistd.h needed for pread/pwrite (seen with Suse): lib/librte_eal/linuxapp/eal/eal_pci_uio.c:62:2: error: implicit declaration of function ?pread? Fixes: 4a499c649590 ("eal/linux: enable uio_pci_generic support") Signed-of