Re: [dpdk-dev] [PATCH] drivers/net: fix FW version get

2021-04-28 Thread Yang, Qiming
Hi, > -Original Message- > From: Yigit, Ferruh > Sent: Thursday, April 22, 2021 00:21 > To: Igor Russkikh ; Pavel Belous > ; Somalapuram Amaranath > ; Ajit Khaparde ; > Somnath Kotur ; Hemant Agrawal > ; Sachin Saxena > ; Guo, Jia ; Wang, Haiyue > ; Daley, John ; Hyong Youb > Kim ; Min H

Re: [dpdk-dev] [PATCH] drivers/net: fix FW version get

2021-04-22 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH] drivers/net: fix FW version get

2021-04-22 Thread Jiawen Wu
On April 22, 2021 12:21 AM, Ferruh Yigit wrote: > Fixes a few different things: > * Remove 'fw_version' NULL checks, it is allowed if the 'fw_size' is > zero, 'fw_version' being NULL but 'fw_size' not zero condition checked > in ethdev layer > * Be sure required buffer size is returned if provi

Re: [dpdk-dev] [PATCH] drivers/net: fix FW version get

2021-04-22 Thread Xing, Beilei
> -Original Message- > From: Yigit, Ferruh > Sent: Thursday, April 22, 2021 12:21 AM > To: Igor Russkikh ; Pavel Belous > ; Somalapuram Amaranath > ; Ajit Khaparde ; > Somnath Kotur ; Hemant Agrawal > ; Sachin Saxena ; > Guo, Jia ; Wang, Haiyue ; > Daley, John ; Hyong Youb Kim ; > Min H

Re: [dpdk-dev] [PATCH] drivers/net: fix FW version get

2021-04-22 Thread Jiawen Wu
On April 22, 2021 12:21 AM, Ferruh Yigit wrote: > Fixes a few different things: > * Remove 'fw_version' NULL checks, it is allowed if the 'fw_size' is > zero, 'fw_version' being NULL but 'fw_size' not zero condition checked > in ethdev layer > * Be sure required buffer size is returned if provi

Re: [dpdk-dev] [PATCH] drivers/net: fix FW version get

2021-04-22 Thread Wang, Haiyue
> -Original Message- > From: Yigit, Ferruh > Sent: Thursday, April 22, 2021 00:21 > To: Igor Russkikh ; Pavel Belous > ; Somalapuram > Amaranath ; Ajit Khaparde ; > Somnath Kotur > ; Hemant Agrawal ; Sachin > Saxena > ; Guo, Jia ; Wang, Haiyue > ; Daley, > John ; Hyong Youb Kim ; Min H

Re: [dpdk-dev] [PATCH] drivers/net: fix FW version get

2021-04-22 Thread Andrew Rybchenko
On 4/21/21 7:30 PM, Ajit Khaparde wrote: > On Wed, Apr 21, 2021 at 9:21 AM Ferruh Yigit wrote: >> >> Fixes a few different things: >> * Remove 'fw_version' NULL checks, it is allowed if the 'fw_size' is >> zero, 'fw_version' being NULL but 'fw_size' not zero condition checked >> in ethdev laye

Re: [dpdk-dev] [PATCH] drivers/net: fix FW version get

2021-04-21 Thread Ajit Khaparde
On Wed, Apr 21, 2021 at 9:21 AM Ferruh Yigit wrote: > > Fixes a few different things: > * Remove 'fw_version' NULL checks, it is allowed if the 'fw_size' is > zero, 'fw_version' being NULL but 'fw_size' not zero condition checked > in ethdev layer > * Be sure required buffer size is returned i

[dpdk-dev] [PATCH] drivers/net: fix FW version get

2021-04-21 Thread Ferruh Yigit
Fixes a few different things: * Remove 'fw_version' NULL checks, it is allowed if the 'fw_size' is zero, 'fw_version' being NULL but 'fw_size' not zero condition checked in ethdev layer * Be sure required buffer size is returned if provided one is not big enough, instead of returning success