Re: [dpdk-dev] [PATCH] drivers/net/i40e/:remove i40e_nvmupd_command redundant code

2018-09-29 Thread Zhang, Qi Z
Hi Han: > -Original Message- > From: Li Han [mailto:han@zte.com.cn] > Sent: Thursday, September 27, 2018 3:27 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Li Han > Subject: [PATCH] [dpdk-dev] drivers/net/i40e/:remove > i40e_nvmupd_command redundant code > > in function i40e_nvmupd_valid

[dpdk-dev] [PATCH] drivers/net/i40e/:remove i40e_nvmupd_command redundant code

2018-09-27 Thread Li Han
in function i40e_nvmupd_validate_command, when "cmd->data_size < 1" it'll return I40E_NVMUPD_INVALID,and in function "i40e_nvmupd_command" when "upd_cmd == I40E_NVMUPD_STATUS",it check "!cmd->data_size" again, but it's no need. Signed-off-by: Li Han --- drivers/net/i40e/base/i40e_nvm.c | 5 -

[dpdk-dev] [PATCH] drivers/net/i40e/:remove i40e_nvmupd_command redundant code in function i40e_nvmupd_validate_command, when "cmd->data_size < 1" it'll return I40E_NVMUPD_INVALID, and in function "i4

2018-09-27 Thread Li Han
Signed-off-by: Li Han --- drivers/net/i40e/base/i40e_nvm.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/net/i40e/base/i40e_nvm.c b/drivers/net/i40e/base/i40e_nvm.c index c77dac0..5de22e4 100644 --- a/drivers/net/i40e/base/i40e_nvm.c +++ b/drivers/net/i40e/base/i40e_nvm.c @@ -86