Re: [dpdk-dev] [PATCH] doc: update RSS action with best effort

2020-09-14 Thread Ferruh Yigit
On 8/3/2020 4:55 PM, Andrew Rybchenko wrote: > On 8/3/20 6:49 PM, Ori Kam wrote: >> Hi David, >> >>> -Original Message- >>> From: David Marchand >>> >>> On Mon, Aug 3, 2020 at 5:23 PM Ori Kam wrote: >> + >> +- Hashing on types that are not supported by the PMD. > Shouldn't it

Re: [dpdk-dev] [PATCH] doc: update RSS action with best effort

2020-08-03 Thread Ori Kam
Hi Andrew, > -Original Message- > From: Andrew Rybchenko > > On 8/3/20 6:47 PM, Ori Kam wrote: > > > > > >> -Original Message- > >> From: Andrew Rybchenko > >> > >> On 8/3/20 6:22 PM, Ori Kam wrote: > >>> Hi Andrew, > >>> > -Original Message- > From: Andrew Ryb

Re: [dpdk-dev] [PATCH] doc: update RSS action with best effort

2020-08-03 Thread Thomas Monjalon
03/08/2020 17:55, Andrew Rybchenko: > On 8/3/20 6:49 PM, Ori Kam wrote: > > From: David Marchand > >> On Mon, Aug 3, 2020 at 5:23 PM Ori Kam wrote: > > + > > +- Hashing on types that are not supported by the PMD. > Shouldn't it return error to the caller? > > >>> That’s depends,

Re: [dpdk-dev] [PATCH] doc: update RSS action with best effort

2020-08-03 Thread Andrew Rybchenko
On 8/3/20 6:47 PM, Ori Kam wrote: > > >> -Original Message- >> From: Andrew Rybchenko >> >> On 8/3/20 6:22 PM, Ori Kam wrote: >>> Hi Andrew, >>> -Original Message- From: Andrew Rybchenko On 8/3/20 5:28 PM, Ori Kam wrote: > Using the rte_flow action RSS ty

Re: [dpdk-dev] [PATCH] doc: update RSS action with best effort

2020-08-03 Thread Andrew Rybchenko
On 8/3/20 6:49 PM, Ori Kam wrote: > Hi David, > >> -Original Message- >> From: David Marchand >> >> On Mon, Aug 3, 2020 at 5:23 PM Ori Kam wrote: > + > +- Hashing on types that are not supported by the PMD. Shouldn't it return error to the caller? >>> That’s depends, if

Re: [dpdk-dev] [PATCH] doc: update RSS action with best effort

2020-08-03 Thread Ori Kam
Hi David, > -Original Message- > From: David Marchand > > On Mon, Aug 3, 2020 at 5:23 PM Ori Kam wrote: > > > > + > > > > +- Hashing on types that are not supported by the PMD. > > > > > > Shouldn't it return error to the caller? > > > > > That’s depends, if for example the application

Re: [dpdk-dev] [PATCH] doc: update RSS action with best effort

2020-08-03 Thread Ori Kam
> -Original Message- > From: Andrew Rybchenko > > On 8/3/20 6:22 PM, Ori Kam wrote: > > Hi Andrew, > > > >> -Original Message- > >> From: Andrew Rybchenko > >> > >> On 8/3/20 5:28 PM, Ori Kam wrote: > >>> Using the rte_flow action RSS types field, > >>> may result in an undefin

Re: [dpdk-dev] [PATCH] doc: update RSS action with best effort

2020-08-03 Thread David Marchand
On Mon, Aug 3, 2020 at 5:23 PM Ori Kam wrote: > > > + > > > +- Hashing on types that are not supported by the PMD. > > > > Shouldn't it return error to the caller? > > > That’s depends, if for example the application requested eth and IPv4, > and the PMD can do only IPv4 so according to this, the

Re: [dpdk-dev] [PATCH] doc: update RSS action with best effort

2020-08-03 Thread Andrew Rybchenko
On 8/3/20 6:22 PM, Ori Kam wrote: > Hi Andrew, > >> -Original Message- >> From: Andrew Rybchenko >> >> On 8/3/20 5:28 PM, Ori Kam wrote: >>> Using the rte_flow action RSS types field, >>> may result in an undefined outcome. >>> >>> For example selecting both UDP and TCP, >>> selecting TCP

Re: [dpdk-dev] [PATCH] doc: update RSS action with best effort

2020-08-03 Thread Ori Kam
Hi Andrew, > -Original Message- > From: Andrew Rybchenko > > On 8/3/20 5:28 PM, Ori Kam wrote: > > Using the rte_flow action RSS types field, > > may result in an undefined outcome. > > > > For example selecting both UDP and TCP, > > selecting TCP RSS type but the pattern is targeting UD

Re: [dpdk-dev] [PATCH] doc: update RSS action with best effort

2020-08-03 Thread Andrew Rybchenko
On 8/3/20 5:28 PM, Ori Kam wrote: > Using the rte_flow action RSS types field, > may result in an undefined outcome. > > For example selecting both UDP and TCP, > selecting TCP RSS type but the pattern is targeting UDP traffic. > another option is that the PMD doesn't support all requested types.

[dpdk-dev] [PATCH] doc: update RSS action with best effort

2020-08-03 Thread Ori Kam
Using the rte_flow action RSS types field, may result in an undefined outcome. For example selecting both UDP and TCP, selecting TCP RSS type but the pattern is targeting UDP traffic. another option is that the PMD doesn't support all requested types. Until now, it wasn't clear what will happen i