Re: [dpdk-dev] [PATCH] doc: coding style: use linux kernel style for indentation

2018-02-13 Thread Yuanhan Liu
On Tue, Feb 13, 2018 at 12:51:57PM +, Ferruh Yigit wrote: > On 1/13/2016 4:49 PM, stephen at networkplumber.org (Stephen Hemminger) wrote: > > On Wed, 13 Jan 2016 15:07:08 + > > Bruce Richardson wrote: > > > >> So, while the two-tab indent may look "a bit weird" it does solve the two > >

Re: [dpdk-dev] [PATCH] doc: coding style: use linux kernel style for indentation

2018-02-13 Thread Ferruh Yigit
On 1/13/2016 4:49 PM, stephen at networkplumber.org (Stephen Hemminger) wrote: > On Wed, 13 Jan 2016 15:07:08 + > Bruce Richardson wrote: > >> So, while the two-tab indent may look "a bit weird" it does solve the two >> issues >> above. I believe practical benefits should override initial im

[dpdk-dev] [PATCH] doc: coding style: use linux kernel style for indentation

2016-01-13 Thread Yuanhan Liu
Using two tabs for "if" (or "while") statements is a bit weird to me. Also, using one tab unconditionaly for function definitions and prototypes doesn't look great. Here I'd suggest to use the indentation style the Linux kernel project prefers: to align with the open brace with tabs and additonal

[dpdk-dev] [PATCH] doc: coding style: use linux kernel style for indentation

2016-01-13 Thread Bruce Richardson
On Wed, Jan 13, 2016 at 03:58:49PM +0800, Yuanhan Liu wrote: > Using two tabs for "if" (or "while") statements is a bit weird to me. > Also, using one tab unconditionaly for function definitions and > prototypes doesn't look great. > > Here I'd suggest to use the indentation style the Linux kernel

[dpdk-dev] [PATCH] doc: coding style: use linux kernel style for indentation

2016-01-13 Thread Stephen Hemminger
On Wed, 13 Jan 2016 15:07:08 + Bruce Richardson wrote: > So, while the two-tab indent may look "a bit weird" it does solve the two > issues > above. I believe practical benefits should override initial impressions. [It > took > me a while to get used to also, but now I very much like it as