Re: [dpdk-dev] [PATCH] devtools: trap SIGINT is not recognizable to dash

2018-08-06 Thread Stephen Hemminger
On Sat, 4 Aug 2018 06:42:53 + Gavin Hu wrote: > Hi Stephen, > > I am no sure only supporting bash is acceptable or not. Any impact to freebsd? > > We should seek wider opinions about this. > > I did not meet your problem, either bash or dash, what's your shell? > > Best Regards, > Gavin

Re: [dpdk-dev] [PATCH] devtools: trap SIGINT is not recognizable to dash

2018-08-03 Thread Gavin Hu
ger > Sent: Saturday, August 4, 2018 6:17 AM > To: Gavin Hu > Cc: dev@dpdk.org; Honnappa Nagarahalli > ; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] devtools: trap SIGINT is not recognizable to > dash > > On Wed, 1 Aug 2018 13:22:57 +0800 > Gavin Hu wrote: > > &g

Re: [dpdk-dev] [PATCH] devtools: trap SIGINT is not recognizable to dash

2018-08-03 Thread Stephen Hemminger
On Wed, 1 Aug 2018 13:22:57 +0800 Gavin Hu wrote: > When running checkpatch.sh, it generates the following error > on some linux distributions(like Debian) with Dash as the > default shell interpreter. > trap: SIGINT: bad trap > > The fix is to replace SIGINT with INT signal, it works for > bot

[dpdk-dev] [PATCH] devtools: trap SIGINT is not recognizable to dash

2018-07-31 Thread Gavin Hu
When running checkpatch.sh, it generates the following error on some linux distributions(like Debian) with Dash as the default shell interpreter. trap: SIGINT: bad trap The fix is to replace SIGINT with INT signal, it works for both bash and dash. Fixes: 4bec48184e ("devtools: add checks for ABI