Re: [dpdk-dev] [PATCH] devtools: skip the symbol check when map file under drivers

2019-05-23 Thread Neil Horman
On Thu, May 23, 2019 at 08:59:07PM +0200, Thomas Monjalon wrote: > 23/05/2019 19:57, Neil Horman: > > On Thu, May 23, 2019 at 02:21:29PM +, Jerin Jacob Kollanukkaran wrote: > > > From: Neil Horman > > > > > > > > > IMO, The name prefix matters. The rte_* should denote it a > > > > > > > > > DP

Re: [dpdk-dev] [PATCH] devtools: skip the symbol check when map file under drivers

2019-05-23 Thread Thomas Monjalon
23/05/2019 19:57, Neil Horman: > On Thu, May 23, 2019 at 02:21:29PM +, Jerin Jacob Kollanukkaran wrote: > > From: Neil Horman > > > > > > > > IMO, The name prefix matters. The rte_* should denote it a > > > > > > > > DPDK API and application suppose to use it. > > > > > > > > > > > > > > > It

Re: [dpdk-dev] [PATCH] devtools: skip the symbol check when map file under drivers

2019-05-23 Thread Neil Horman
On Thu, May 23, 2019 at 02:21:29PM +, Jerin Jacob Kollanukkaran wrote: > > > > -Original Message- > > From: Neil Horman > > Sent: Thursday, May 23, 2019 12:29 AM > > To: Jerin Jacob Kollanukkaran > > Cc: Bruce Richardson ; dev@dpdk.org; > > tho...@monjalon.net; sta...@dpdk.org > > S

Re: [dpdk-dev] [PATCH] devtools: skip the symbol check when map file under drivers

2019-05-23 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Neil Horman > Sent: Thursday, May 23, 2019 12:29 AM > To: Jerin Jacob Kollanukkaran > Cc: Bruce Richardson ; dev@dpdk.org; > tho...@monjalon.net; sta...@dpdk.org > Subject: Re: [EXT] Re: [dpdk-dev] Re: [PATCH] devtools: skip the symbol > check when map file

Re: [dpdk-dev] [PATCH] devtools: skip the symbol check when map file under drivers

2019-05-22 Thread Neil Horman
On Wed, May 22, 2019 at 04:12:40PM +0200, Thomas Monjalon wrote: > 22/05/2019 15:40, Neil Horman: > > On Wed, May 22, 2019 at 01:12:34PM +, Jerin Jacob Kollanukkaran wrote: > > > From: Neil Horman > > > > On Wed, May 22, 2019 at 03:05:54AM +, Jerin Jacob Kollanukkaran > > > > wrote: > > >

Re: [dpdk-dev] [PATCH] devtools: skip the symbol check when map file under drivers

2019-05-22 Thread Thomas Monjalon
22/05/2019 15:40, Neil Horman: > On Wed, May 22, 2019 at 01:12:34PM +, Jerin Jacob Kollanukkaran wrote: > > From: Neil Horman > > > On Wed, May 22, 2019 at 03:05:54AM +, Jerin Jacob Kollanukkaran > > > wrote: > > > > From: Neil Horman > > > > > On Wed, May 22, 2019 at 01:26:28AM +0530, je

Re: [dpdk-dev] [PATCH] devtools: skip the symbol check when map file under drivers

2019-05-22 Thread Neil Horman
On Wed, May 22, 2019 at 01:41:03PM +, Jerin Jacob Kollanukkaran wrote: > > -Original Message- > > From: Neil Horman > > Sent: Wednesday, May 22, 2019 6:43 PM > > To: Jerin Jacob Kollanukkaran > > Cc: Bruce Richardson ; dev@dpdk.org; > > tho...@monjalon.net; sta...@dpdk.org > > Subject

Re: [dpdk-dev] [PATCH] devtools: skip the symbol check when map file under drivers

2019-05-22 Thread Neil Horman
: Neil Horman > > > > Sent: Wednesday, May 22, 2019 1:57 AM > > > > To: Jerin Jacob Kollanukkaran > > > > Cc: dev@dpdk.org; tho...@monjalon.net; sta...@dpdk.org > > > > Subject: [EXT] Re: [dpdk-dev] [PATCH] devtools: skip the symbol > > > > c

Re: [dpdk-dev] [PATCH] devtools: skip the symbol check when map file under drivers

2019-05-22 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Neil Horman > Sent: Wednesday, May 22, 2019 6:43 PM > To: Jerin Jacob Kollanukkaran > Cc: Bruce Richardson ; dev@dpdk.org; > tho...@monjalon.net; sta...@dpdk.org > Subject: [EXT] Re: [dpdk-dev] Re: [PATCH] devtools: skip the symbol check > when map file under

Re: [dpdk-dev] [PATCH] devtools: skip the symbol check when map file under drivers

2019-05-22 Thread Neil Horman
On Wed, May 22, 2019 at 11:54:13AM +, Jerin Jacob Kollanukkaran wrote: > > -Original Message- > > From: Bruce Richardson > > Sent: Wednesday, May 22, 2019 4:21 PM > > To: Jerin Jacob Kollanukkaran > > Cc: Neil Horman ; dev@dpdk.org; > > tho...@monjalon.net; sta...@dpdk.org > > Subject

Re: [dpdk-dev] [PATCH] devtools: skip the symbol check when map file under drivers

2019-05-22 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Neil Horman > Sent: Wednesday, May 22, 2019 6:16 PM > To: Jerin Jacob Kollanukkaran > Cc: dev@dpdk.org; tho...@monjalon.net; sta...@dpdk.org > Subject: Re: [EXT] Re: [dpdk-dev] [PATCH] devtools: skip the symbol check > when map file unde

Re: [dpdk-dev] [PATCH] devtools: skip the symbol check when map file under drivers

2019-05-22 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Bruce Richardson > Sent: Wednesday, May 22, 2019 4:21 PM > To: Jerin Jacob Kollanukkaran > Cc: Neil Horman ; dev@dpdk.org; > tho...@monjalon.net; sta...@dpdk.org > Subject: Re: [dpdk-dev] [EXT] Re: [PATCH] devtools: skip the symbol check > when map file under

Re: [dpdk-dev] [PATCH] devtools: skip the symbol check when map file under drivers

2019-05-21 Thread Neil Horman
On Wed, May 22, 2019 at 01:26:28AM +0530, jer...@marvell.com wrote: > From: Jerin Jacob > > Drivers do not have ABI. > Skip the symbol check if map file under drivers directory. > > Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition") > > Cc: sta...@dpdk.org > Cc: Neil Horman >

[dpdk-dev] [PATCH] devtools: skip the symbol check when map file under drivers

2019-05-21 Thread jerinj
From: Jerin Jacob Drivers do not have ABI. Skip the symbol check if map file under drivers directory. Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition") Cc: sta...@dpdk.org Cc: Neil Horman Signed-off-by: Jerin Jacob --- devtools/check-symbol-change.sh | 8 1 file