Re: [dpdk-dev] [PATCH] devtools: skip ABI check in static builds

2020-04-21 Thread Thomas Monjalon
21/04/2020 10:02, David Marchand: > On Tue, Apr 21, 2020 at 3:33 AM Thomas Monjalon wrote: > > > > When running make with CONFIG_RTE_BUILD_SHARED_LIB=n, > > no shared library is built. > > In this case, no need to run ABI check. > > > > With meson, both shared and static libraries are always built

Re: [dpdk-dev] [PATCH] devtools: skip ABI check in static builds

2020-04-21 Thread Thomas Monjalon
21/04/2020 08:11, Ray Kinsella: > > On 21/04/2020 02:33, Thomas Monjalon wrote: > > When running make with CONFIG_RTE_BUILD_SHARED_LIB=n, > > no shared library is built. > > In this case, no need to run ABI check. > > > > With meson, both shared and static libraries are always built. > > You can

Re: [dpdk-dev] [PATCH] devtools: skip ABI check in static builds

2020-04-21 Thread David Marchand
On Tue, Apr 21, 2020 at 3:33 AM Thomas Monjalon wrote: > > When running make with CONFIG_RTE_BUILD_SHARED_LIB=n, > no shared library is built. > In this case, no need to run ABI check. > > With meson, both shared and static libraries are always built. > > Signed-off-by: Thomas Monjalon Acked-by:

Re: [dpdk-dev] [PATCH] devtools: skip ABI check in static builds

2020-04-20 Thread Ray Kinsella
On 21/04/2020 02:33, Thomas Monjalon wrote: > When running make with CONFIG_RTE_BUILD_SHARED_LIB=n, > no shared library is built. > In this case, no need to run ABI check. > > With meson, both shared and static libraries are always built. You can easily do the same thing for meson, by checking

[dpdk-dev] [PATCH] devtools: skip ABI check in static builds

2020-04-20 Thread Thomas Monjalon
When running make with CONFIG_RTE_BUILD_SHARED_LIB=n, no shared library is built. In this case, no need to run ABI check. With meson, both shared and static libraries are always built. Signed-off-by: Thomas Monjalon --- devtools/test-build.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/