Re: [dpdk-dev] [PATCH] devtools: refuse indent with tabs in Meson

2021-11-02 Thread David Marchand
On Wed, Oct 27, 2021 at 11:57 AM Bruce Richardson wrote: > > On Fri, Oct 22, 2021 at 10:55:31PM +0200, David Marchand wrote: > > The rule for indentation in Meson in DPDK is 4 spaces. > > > > Any tab should be flagged as an issue, let's extend the check and fix > > existing offenders. > > > > Fixe

Re: [dpdk-dev] [PATCH] devtools: refuse indent with tabs in Meson

2021-11-02 Thread David Marchand
On Tue, Nov 2, 2021 at 7:16 PM Stephen Hemminger wrote: > > On Fri, 22 Oct 2021 22:55:31 +0200 > David Marchand wrote: > > > The rule for indentation in Meson in DPDK is 4 spaces. > > > > Any tab should be flagged as an issue, let's extend the check and fix > > existing offenders. > > > > Fixes:

Re: [dpdk-dev] [PATCH] devtools: refuse indent with tabs in Meson

2021-11-02 Thread Stephen Hemminger
On Fri, 22 Oct 2021 22:55:31 +0200 David Marchand wrote: > The rule for indentation in Meson in DPDK is 4 spaces. > > Any tab should be flagged as an issue, let's extend the check and fix > existing offenders. > > Fixes: 4ad4b20a7905 ("drivers: change indentation in build files") > Fixes: 24577

Re: [dpdk-dev] [PATCH] devtools: refuse indent with tabs in Meson

2021-11-02 Thread Bruce Richardson
On Tue, Nov 02, 2021 at 06:48:07PM +0100, David Marchand wrote: > On Wed, Oct 27, 2021 at 11:57 AM Bruce Richardson > wrote: > > I wonder is there ever any scenario where we want to allow tabs on a line? > > If not, then rather than using regex, the check could be simplified to: > > > > if

Re: [dpdk-dev] [PATCH] devtools: refuse indent with tabs in Meson

2021-11-02 Thread David Marchand
On Wed, Oct 27, 2021 at 11:57 AM Bruce Richardson wrote: > I wonder is there ever any scenario where we want to allow tabs on a line? > If not, then rather than using regex, the check could be simplified to: > > if '\t' in line: I am not sure. I considered cases with tabs in log messages.

Re: [dpdk-dev] [PATCH] devtools: refuse indent with tabs in Meson

2021-10-27 Thread Bruce Richardson
On Fri, Oct 22, 2021 at 10:55:31PM +0200, David Marchand wrote: > The rule for indentation in Meson in DPDK is 4 spaces. > > Any tab should be flagged as an issue, let's extend the check and fix > existing offenders. > > Fixes: 4ad4b20a7905 ("drivers: change indentation in build files") > Fixes:

[dpdk-dev] [PATCH] devtools: refuse indent with tabs in Meson

2021-10-22 Thread David Marchand
The rule for indentation in Meson in DPDK is 4 spaces. Any tab should be flagged as an issue, let's extend the check and fix existing offenders. Fixes: 4ad4b20a7905 ("drivers: change indentation in build files") Fixes: 2457705e6474 ("crypto/cnxk: add driver skeleton") Fixes: 634b73104482 ("app/te