Re: [dpdk-dev] [PATCH] devtools: ignore PREFER_FALLTHROUGH

2020-08-07 Thread Thomas Monjalon
05/08/2020 15:54, Thomas Monjalon: > 05/08/2020 15:34, Adrian Moreno: > > On 8/5/20 11:12 AM, Thomas Monjalon wrote: > > > 04/08/2020 09:38, Adrian Moreno: > > >> --- a/devtools/checkpatches.sh > > >> +++ b/devtools/checkpatches.sh > > >> @@ -33,7 +33,7 @@ VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREF

Re: [dpdk-dev] [PATCH] devtools: ignore PREFER_FALLTHROUGH

2020-08-05 Thread Thomas Monjalon
05/08/2020 15:34, Adrian Moreno: > Hi Thomas, > > On 8/5/20 11:12 AM, Thomas Monjalon wrote: > > 04/08/2020 09:38, Adrian Moreno: > >> The PREFER_FALLTHROUGH check warns if a passthrough comment is found > >> because, in the kernel, the special macro "fallthrough" is prefered. > >> > >> Since that

Re: [dpdk-dev] [PATCH] devtools: ignore PREFER_FALLTHROUGH

2020-08-05 Thread Adrian Moreno
Hi Thomas, On 8/5/20 11:12 AM, Thomas Monjalon wrote: > 04/08/2020 09:38, Adrian Moreno: >> The PREFER_FALLTHROUGH check warns if a passthrough comment is found >> because, in the kernel, the special macro "fallthrough" is prefered. >> >> Since that keyword is not defined in DPDK, ignore the warni

Re: [dpdk-dev] [PATCH] devtools: ignore PREFER_FALLTHROUGH

2020-08-05 Thread Thomas Monjalon
04/08/2020 09:38, Adrian Moreno: > The PREFER_FALLTHROUGH check warns if a passthrough comment is found > because, in the kernel, the special macro "fallthrough" is prefered. > > Since that keyword is not defined in DPDK, ignore the warning. We could ask why not defining a similar keyword? > >

Re: [dpdk-dev] [PATCH] devtools: ignore PREFER_FALLTHROUGH

2020-08-04 Thread Xia, Chenbo
> -Original Message- > From: Adrian Moreno > Sent: Tuesday, August 4, 2020 3:39 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; Xia, Chenbo ; > david.march...@redhat.com; Adrian Moreno > Subject: [PATCH] devtools: ignore PREFER_FALLTHROUGH > > The PREFER_FALLTHROUGH check warns if a p

Re: [dpdk-dev] [PATCH] devtools: ignore PREFER_FALLTHROUGH

2020-08-04 Thread Ferruh Yigit
On 8/4/2020 8:38 AM, Adrian Moreno wrote: > The PREFER_FALLTHROUGH check warns if a passthrough comment is found > because, in the kernel, the special macro "fallthrough" is prefered. > > Since that keyword is not defined in DPDK, ignore the warning. > > Ignoring this check does not affect the MI

[dpdk-dev] [PATCH] devtools: ignore PREFER_FALLTHROUGH

2020-08-04 Thread Adrian Moreno
The PREFER_FALLTHROUGH check warns if a passthrough comment is found because, in the kernel, the special macro "fallthrough" is prefered. Since that keyword is not defined in DPDK, ignore the warning. Ignoring this check does not affect the MISSING_BREAK check that will warn if a switch case/defa