Re: [dpdk-dev] [PATCH] dev: fix attach rollback of a device that was already attached

2018-11-23 Thread Stojaczyk, Dariusz
> -Original Message- > From: Zhang, Qi Z > Sent: Friday, November 23, 2018 8:11 PM > To: Stojaczyk, Dariusz ; dev@dpdk.org > Cc: tho...@monjalon.net > Subject: RE: [PATCH] dev: fix attach rollback of a device that was already > attached > > > > > -Original Message- > > From: S

Re: [dpdk-dev] [PATCH] dev: fix attach rollback of a device that was already attached

2018-11-23 Thread Zhang, Qi Z
> -Original Message- > From: Stojaczyk, Dariusz > Sent: Friday, November 23, 2018 6:45 AM > To: dev@dpdk.org > Cc: tho...@monjalon.net; Stojaczyk, Dariusz ; > Zhang, Qi Z > Subject: [PATCH] dev: fix attach rollback of a device that was already > attached > > When primary process recei

[dpdk-dev] [PATCH] dev: fix attach rollback of a device that was already attached

2018-11-23 Thread Darek Stojaczyk
When primary process receives an IPC attach request of a device that's already locally-attached, it doesn't setup its variables properly and is prone to segfaulting on a subsequent rollback. `ret = local_dev_probe(req->devargs, &dev)` The above function will set `dev` pointer to the proper device