Re: [dpdk-dev] [PATCH] common/mlx5: fix bogus assert

2020-04-13 Thread Slava Ovsiienko
> -Original Message- > From: Stephen Hemminger > Sent: Friday, April 10, 2020 20:15 > To: Slava Ovsiienko > Cc: Matan Azrad ; Shahaf Shuler > ; dev@dpdk.org; Alexander Kozyrev > > Subject: Re: [PATCH] common/mlx5: fix bogus assert > > On Tue, 31 Mar 2020 15:09:43 + > Slava Ovsiien

Re: [dpdk-dev] [PATCH] common/mlx5: fix bogus assert

2020-04-10 Thread Stephen Hemminger
On Tue, 31 Mar 2020 15:09:43 + Slava Ovsiienko wrote: > > -Original Message- > > From: Stephen Hemminger > > Sent: Tuesday, March 31, 2020 17:55 > > To: Slava Ovsiienko > > Cc: Matan Azrad ; Shahaf Shuler > > ; dev@dpdk.org; Alexander Kozyrev > > > > Subject: Re: [PATCH] common/mlx

Re: [dpdk-dev] [PATCH] common/mlx5: fix bogus assert

2020-03-31 Thread Slava Ovsiienko
> -Original Message- > From: Stephen Hemminger > Sent: Tuesday, March 31, 2020 17:55 > To: Slava Ovsiienko > Cc: Matan Azrad ; Shahaf Shuler > ; dev@dpdk.org; Alexander Kozyrev > > Subject: Re: [PATCH] common/mlx5: fix bogus assert > > On Tue, 31 Mar 2020 07:31:48 + > Slava Ovsiienk

Re: [dpdk-dev] [PATCH] common/mlx5: fix bogus assert

2020-03-31 Thread Stephen Hemminger
On Tue, 31 Mar 2020 07:31:48 + Slava Ovsiienko wrote: > Hi, Stephen > > Thank you for the fix. > > The exposed API to set MAC addresses: > - mlx5_mac_addr_set (invoked by rte_mac_addr_set ()) > - mlx5_set_mc_addr_list (invoked by rte_eth_dev_set_mc_addr_list()) > > Both routines call mlx5_

Re: [dpdk-dev] [PATCH] common/mlx5: fix bogus assert

2020-03-31 Thread Slava Ovsiienko
Hi, Stephen Thank you for the fix. The exposed API to set MAC addresses: - mlx5_mac_addr_set (invoked by rte_mac_addr_set ()) - mlx5_set_mc_addr_list (invoked by rte_eth_dev_set_mc_addr_list()) Both routines call mlx5_internal_mac_addr_add(), it in its turn calls mlx5_nl_mac_addr_add() (that is

[dpdk-dev] [PATCH] common/mlx5: fix bogus assert

2020-03-30 Thread Stephen Hemminger
The MLX5 device supports up to 256 MAC addresses. The code flushes all MAC devices. If DPDK is compiled with MLX5_DEBUG this would an assert. PANIC in mlx5_nl_mac_addr_flush(): line 775assert "(size_t)(i) < sizeof(mac_own) * 8" failed The root cause is that mac_own is a pointer and is bei