Re: [dpdk-dev] [PATCH] cmdline: replace FreeBSD ifdef for IP address parsing

2019-11-08 Thread Thomas Monjalon
08/11/2019 17:15, Stephen Hemminger: > On Wed, 6 Nov 2019 13:09:43 +0100 > Thomas Monjalon wrote: > > > The constants like AF_INET are in sys/socket.h in FreeBSD. > > The #ifdef macro __FreeBSD__ is replaced with RTE_EXEC_ENV_FREEBSD > > in order to be consistent across DPDK files, and allow to

Re: [dpdk-dev] [PATCH] cmdline: replace FreeBSD ifdef for IP address parsing

2019-11-08 Thread Stephen Hemminger
On Wed, 6 Nov 2019 13:09:43 +0100 Thomas Monjalon wrote: > The constants like AF_INET are in sys/socket.h in FreeBSD. > The #ifdef macro __FreeBSD__ is replaced with RTE_EXEC_ENV_FREEBSD > in order to be consistent across DPDK files, and allow to grep > for EXEC_ENV among other benefits. > > Si

Re: [dpdk-dev] [PATCH] cmdline: replace FreeBSD ifdef for IP address parsing

2019-11-08 Thread David Marchand
On Fri, Nov 8, 2019 at 9:44 AM Olivier Matz wrote: > > On Wed, Nov 06, 2019 at 01:09:43PM +0100, Thomas Monjalon wrote: > > The constants like AF_INET are in sys/socket.h in FreeBSD. > > The #ifdef macro __FreeBSD__ is replaced with RTE_EXEC_ENV_FREEBSD > > in order to be consistent across DPDK fi

Re: [dpdk-dev] [PATCH] cmdline: replace FreeBSD ifdef for IP address parsing

2019-11-08 Thread Olivier Matz
On Wed, Nov 06, 2019 at 01:09:43PM +0100, Thomas Monjalon wrote: > The constants like AF_INET are in sys/socket.h in FreeBSD. > The #ifdef macro __FreeBSD__ is replaced with RTE_EXEC_ENV_FREEBSD > in order to be consistent across DPDK files, and allow to grep > for EXEC_ENV among other benefits. >

Re: [dpdk-dev] [PATCH] cmdline: replace FreeBSD ifdef for IP address parsing

2019-11-06 Thread Burakov, Anatoly
On 06-Nov-19 12:09 PM, Thomas Monjalon wrote: The constants like AF_INET are in sys/socket.h in FreeBSD. The #ifdef macro __FreeBSD__ is replaced with RTE_EXEC_ENV_FREEBSD in order to be consistent across DPDK files, and allow to grep for EXEC_ENV among other benefits. Signed-off-by: Thomas Monj

[dpdk-dev] [PATCH] cmdline: replace FreeBSD ifdef for IP address parsing

2019-11-06 Thread Thomas Monjalon
The constants like AF_INET are in sys/socket.h in FreeBSD. The #ifdef macro __FreeBSD__ is replaced with RTE_EXEC_ENV_FREEBSD in order to be consistent across DPDK files, and allow to grep for EXEC_ENV among other benefits. Signed-off-by: Thomas Monjalon --- app/test-pmd/cmdline.c